Bug 286952
| Summary: | [Flex][Cleanup] Separate out preferred aspect ratio computation in computeMainSizeFromAspectRatioUsing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sammy Gill <sgill26> |
| Component: | Layout and Rendering | Assignee: | Sammy Gill <sgill26> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sammy Gill
We have some different logic doing separate things but are nested in together. This makes it a little hard to read what is going on. We can clean up up a bit by separating our the aspect ratio computation from the rest of it
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/144110644>
Sammy Gill
Pull request: https://github.com/WebKit/WebKit/pull/40059
EWS
Committed 289907@main (c5643953e327): <https://commits.webkit.org/289907@main>
Reviewed commits have been landed. Closing PR #40059 and removing active labels.