WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
286952
[Flex][Cleanup] Separate out preferred aspect ratio computation in computeMainSizeFromAspectRatioUsing
https://bugs.webkit.org/show_bug.cgi?id=286952
Summary
[Flex][Cleanup] Separate out preferred aspect ratio computation in computeMai...
Sammy Gill
Reported
2025-02-03 13:12:19 PST
We have some different logic doing separate things but are nested in together. This makes it a little hard to read what is going on. We can clean up up a bit by separating our the aspect ratio computation from the rest of it
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2025-02-03 13:13:24 PST
<
rdar://problem/144110644
>
Sammy Gill
Comment 2
2025-02-05 10:10:21 PST
Pull request:
https://github.com/WebKit/WebKit/pull/40059
EWS
Comment 3
2025-02-05 19:06:28 PST
Committed
289907@main
(c5643953e327): <
https://commits.webkit.org/289907@main
> Reviewed commits have been landed. Closing PR #40059 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug