Bug 28680

Summary:

WebInspector: Simplify findTreeElement code, get rid of potential infinite loop.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	none
oops - brought isDescendant back (deleted too much).	timothy: review+

Pavel Feldman

Reported 2009-08-24 12:07:08 PDT

Currently searching for inline node text can lead to infinite loop.

Attachments
patch (9.33 KB, patch) 2009-08-24 12:09 PDT, Pavel Feldman	no flags	Details Formatted Diff Diff
oops - brought isDescendant back (deleted too much). (10.29 KB, patch) 2009-08-24 12:19 PDT, Pavel Feldman	timothy: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2009-08-24 12:09:26 PDT

Created attachment 38490 [details] patch

Pavel Feldman

Comment 2 2009-08-24 12:19:19 PDT

Created attachment 38491 [details] oops - brought isDescendant back (deleted too much).

Pavel Feldman

Comment 3 2009-08-24 13:27:34 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ElementsPanel.js M WebCore/inspector/front-end/ElementsTreeOutline.js M WebCore/inspector/front-end/treeoutline.js M WebCore/inspector/front-end/utilities.js Committed r47725

Note You need to log in before you can comment on or make changes to this bug.