Bug 28678

Summary: WebInspector: Only expand local scope when hitting the break
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
same with unused parameter cleanup
none
same with unused parameter cleanup
timothy: review+
second part of the fix timothy: review+

Description Pavel Feldman 2009-08-24 08:39:52 PDT 
Currently all the scopes are being expanded (CallFrame change regression).
Comment 1 Pavel Feldman 2009-08-24 08:41:02 PDT 
Created attachment 38480 [details]
patch
Comment 2 Pavel Feldman 2009-08-24 09:05:18 PDT 
Created attachment 38481 [details]
same with unused parameter cleanup
Comment 3 Pavel Feldman 2009-08-24 09:06:08 PDT 
Created attachment 38482 [details]
same with unused parameter cleanup
Comment 4 Pavel Feldman 2009-08-24 09:41:22 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/InjectedScript.js
	M	WebCore/inspector/front-end/ScopeChainSidebarPane.js
Committed r47717
Comment 5 Pavel Feldman 2009-08-24 12:22:57 PDT 
Created attachment 38492 [details]
second part of the fix

First patch prevents _all_ scopes from being expanded, which is not enough.
I missed the part where local one is expanded.
Comment 6 Pavel Feldman 2009-08-24 13:21:20 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/ScopeChainSidebarPane.js
Committed r47724