Bug 286497
| Summary: | [WebDriver][BiDi] run-webdriver-tests: Selenium WebDriver-BiDi tests require extra pytest option | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Lauro Moura <lmoura> |
| Component: | WebDriver | Assignee: | Lauro Moura <lmoura> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bburg, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Lauro Moura
The selenium test suite update from 288959@main added some WebDriver-BiDi tests. The suite uses the custom `--bidi=true` pytest argument to tell Selenium to start the WebDriver session for testing with this feature enabled.
Currently, this option is not passed to Selenium in WebDriverTestRunnerSelenium/WebDriverSeleniumExecutor. So, running Selenium's WebDriver-BiDi tests fails, regardless of having the feature enabled through `ENABLE_WEBDRIVER_BIDI=1`.
We can't also set it as a fixed flag, as it would make the classic tests to fail in ENABLE_WEBDRIVER_BIDI=0 builds (due to failure to set up the WebDriver-BiDi session).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Lauro Moura
Pull request: https://github.com/WebKit/WebKit/pull/39207
Lauro Moura
Pull request: https://github.com/WebKit/WebKit/pull/39538
Lauro Moura
(In reply to Lauro Moura from comment #1)
> Pull request: https://github.com/WebKit/WebKit/pull/39207
Please ignore this PR, as it is related to bug286163 and was attached to this bug by accident. The correct one is https://github.com/WebKit/WebKit/pull/39538
EWS
Committed 289454@main (9a82bd160050): <https://commits.webkit.org/289454@main>
Reviewed commits have been landed. Closing PR #39538 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/143761444>