Bug 286274
| Summary: | [WebDriver] Properly use smart pointers instead of raw pointers for the HTTPServer, WebSocketServer, and WebDriverService | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Lauro Moura <lmoura> |
| Component: | WebDriver | Assignee: | Lauro Moura <lmoura> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bburg, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=291925 | ||
Lauro Moura
In WebDriverBiDi's a number of classes (WebDriverService, HTTPServer, WebSocketServer) held each other through plain references, and, in the case of WebSocketServer, mixed with WeakPtr usage.
We should make them use smart pointers correctly, per our safer cpp guidelines: https://github.com/WebKit/WebKit/wiki/Safer-CPP-Guidelines#use-smart-pointers-instead-of-raw-pointers-for-all-data-members
Patch incoming.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Lauro Moura
Pull request: https://github.com/WebKit/WebKit/pull/39310
Radar WebKit Bug Importer
<rdar://problem/143715487>
Lauro Moura
(In reply to Lauro Moura from comment #1)
> Pull request: https://github.com/WebKit/WebKit/pull/39310
This PR was closed in favor of a simpler fix in bug291925. We can revisit it later