Bug 286273
| Summary: | [WPE][GTK] libsysprof-capture contains GPLv3+ sources | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, christian, mcatanzaro |
| Priority: | P2 | ||
| Version: | Other | ||
| Hardware: | PC | ||
| OS: | Linux | ||
Michael Catanzaro
The license of Source/ThirdParty/libsysprof-capture/mapped-ring-buffer.c and mapped-ring-buffer.h is GPL-3.0-or-later.
Fortunately this is probably just a mistake. Looks like the intended license is BSD-2-Clause-Patent and these files were just missed in https://gitlab.gnome.org/GNOME/sysprof/-/commit/532972beb66f6db4e9e71933e849dc8529d49be0. I have inquired about relicensing these files.
Maybe we need an EWS to run licensecheck for us so we cannot forget.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
There are also several tests:
Source/ThirdParty/libsysprof-capture/tests/allocs-by-size.c: * the Free Software Foundation, either version 3 of the License, or
Source/ThirdParty/libsysprof-capture/tests/cross-thread-frees.c: * the Free Software Foundation, either version 3 of the License, or
Source/ThirdParty/libsysprof-capture/tests/find-temp-allocs.c: * the Free Software Foundation, either version 3 of the License, or
Source/ThirdParty/libsysprof-capture/tests/rewrite-pid.c: * the Free Software Foundation, either version 3 of the License, or
Source/ThirdParty/libsysprof-capture/tests/test-capture-cursor.c: * the Free Software Foundation, either version 3 of the License, or
But we can simply delete these, and add a note to our WebKit README mentioning to not import them again.
Christian Hergert
It was indeed a mistake. Source is updated to match the other BSD licenses.
Michael Catanzaro
Thank you!
Michael Catanzaro
Pull request: https://github.com/WebKit/WebKit/pull/39299
EWS
Committed 289297@main (e4ef1b87b839): <https://commits.webkit.org/289297@main>
Reviewed commits have been landed. Closing PR #39299 and removing active labels.