Bug 28611

Summary: Middle click panning icon is offset by 3 pixels
Product: WebKit Reporter: philippe.beauchamp
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Trivial CC: aroben, bweinstein, eric, hyatt
Priority: P5    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Changed middlePanningCursor icon size constant and hotspot none

philippe.beauchamp
Reported 2009-08-21 04:39:01 PDT
Reproducing the bug: Open any Web page Click on the Middle mouse button to start panning without moving the mouse. Two Panning icons overlap with a 3x3pixels offset. Panning arrows are also offset by 3x3 pixels during panning action.
Attachments
Changed middlePanningCursor icon size constant and hotspot (1.68 KB, patch)
2009-08-21 05:10 PDT, philippe.beauchamp 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
philippe.beauchamp
Comment 1 2009-08-21 05:10:05 PDT
Created attachment 38368 [details] Changed middlePanningCursor icon size constant and hotspot
Eric Seidel (no email)
Comment 2 2009-08-21 09:19:01 PDT
I don't think you actually want hyatt here. :) I'm surprised we don't get the dimensions from the icon directly instead of hard-coding them. This looks fine, but I'd like one of the windows folks to say OK. (When they do, they can also mark this commit-queue+ since you're not a committer.)
Adam Roben (:aroben)
Comment 3 2009-08-21 09:55:40 PDT
Comment on attachment 38368 [details] Changed middlePanningCursor icon size constant and hotspot Looks fine to me, though I agree it isn't great that we are hard-coding these numbers.
Eric Seidel (no email)
Comment 4 2009-08-21 12:02:29 PDT
Comment on attachment 38368 [details] Changed middlePanningCursor icon size constant and hotspot Clearing flags on attachment: 38368 Committed r47636: <http://trac.webkit.org/changeset/47636>
Eric Seidel (no email)
Comment 5 2009-08-21 12:02:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.