Bug 286061
| Summary: | [GLib] Remove all GLIB_CHECK_VERSION conditionals | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | Platform | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, magomez, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Adrian Perez
The oldest Linux distribution we need to support in 2025 is Ubuntu 22.04,
which ships GLib 2.72.x - and all the GLIB_CHECK_VERSION condiotionals are
for previos versions:
% rg -tcpp -F '#if GLIB_CHECK_VERSION(' --no-filename Source/{WTF,JavaScriptCore/,Web{Core,Kit}} | sort -u
#if GLIB_CHECK_VERSION(2, 59, 0)
#if GLIB_CHECK_VERSION(2, 60, 0)
#if GLIB_CHECK_VERSION(2, 69, 0)
#if GLIB_CHECK_VERSION(2, 69, 1)
% rg -tcpp -F '#if GLIB_CHECK_VERSION(' Source/{WTF,JavaScriptCore/,Web{Core,Kit}} | wl -l
24
%
This means that we could change Source/cmake/Options{GTK,WPE}.cmake to check
for GLib 2.69.1+, and drop all the GLib-version conditional blocks.
Dependencies policy: https://docs.webkit.org/Ports/WebKitGTK%20and%20WPE%20WebKit/DependenciesPolicy.html
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/39129
EWS
Committed 289318@main (85b637b69f1c): <https://commits.webkit.org/289318@main>
Reviewed commits have been landed. Closing PR #39129 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/143526406>