Bug 285489
| Summary: | REGRESSION (288228@main): Compilation fails with Fuzzilli enabled | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jikai Ren <me> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez |
| Priority: | P2 | Keywords: | DoNotImportToRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | Linux | ||
Jikai Ren
Bug Introduce Commit: https://github.com/WebKit/WebKit/commit/e3bc80970566b176f6f2e02c0ffbf3323c0eb19e
Patch:
```diff
diff --git a/Source/JavaScriptCore/fuzzilli/Fuzzilli.cpp b/Source/JavaScriptCore/fuzzilli/Fuzzilli.cpp
index a3d45a9011c5..722e59816d9d 100644
--- a/Source/JavaScriptCore/fuzzilli/Fuzzilli.cpp
+++ b/Source/JavaScriptCore/fuzzilli/Fuzzilli.cpp
@@ -21,12 +21,18 @@
#include "config.h"
#include "Fuzzilli.h"
+#include <unistd.h>
+#include <sys/mman.h>
+#include <sys/stat.h>
+#include <fcntl.h>
+
#include <mutex>
#include <wtf/Assertions.h>
#include <wtf/Compiler.h>
#include <wtf/DataLog.h>
#include <wtf/NeverDestroyed.h>
#include <wtf/StdLibExtras.h>
+#include <wtf/text/ASCIILiteral.h>
#if ENABLE(FUZZILLI)
@@ -139,7 +145,7 @@ void Fuzzilli::initializeReprl()
WRITE_TO_FUZZILLI(helo.data(), helo.size());
READ_FROM_FUZZILLI(helo.data(), helo.size());
- RELEASE_ASSERT_WITH_MESSAGE(equalSpans(helo, "HELO"_span), "[REPRL] Invalid response from parent");
+ RELEASE_ASSERT_WITH_MESSAGE(equalSpans(std::span{helo}, "HELO"_span), "[REPRL] Invalid response from parent");
// Mmap the data input buffer.
reprlInputData = static_cast<char*>(mmap(0, REPRL_MAX_DATA_SIZE, PROT_READ | PROT_WRITE, MAP_SHARED, REPRL_DRFD, 0));
```
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
Thank you for the report! Would you be willing to submit the patch as a GitHub PR for merging into WebKit, https://webkit.org/contributing-code/ ?
Jikai Ren
(In reply to Alexey Proskuryakov from comment #1)
> Thank you for the report! Would you be willing to submit the patch as a
> GitHub PR for merging into WebKit, https://webkit.org/contributing-code/ ?
Sure. Progress will be updated here later.
Jikai Ren
Pull request: https://github.com/WebKit/WebKit/pull/38696
Alexey Proskuryakov
https://commits.webkit.org/288622@main