Bug 285437
| Summary: | Drive By Cleanup Of RenderTreeBuilderMultiColumn | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Yulun Wu <yulun_wu> |
| Component: | Layout and Rendering | Assignee: | Yulun Wu <yulun_wu> |
| Status: | RESOLVED FIXED | ||
| Severity: | Trivial | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P3 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Yulun Wu
We should make two small changes to RenderTreeBuilderMultiColumn to make it easier to follow:
RenderTreeBuilder::MultiColumn::restoreColumnSpannersForContainer()'s argument order is reversed relative to other public functions in the class.
Public/Private functions are intermingled in the .cc file and should be sorted.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Yulun Wu
I'd like to assign this to myself, not sure how to do it in this UI ._.
alan
Try clicking closer to the right edge of the dropdown where there's blank space (this is awful and has been reported)
Yulun Wu
<rdar://problem/142420503>
Yulun Wu
Pull request: https://github.com/WebKit/WebKit/pull/38571
Yulun Wu
Pull request: https://github.com/WebKit/WebKit/pull/38578
Yulun Wu
Thank you Zalan!
Yulun Wu
Thank you Zalan!
EWS
Committed 288490@main (a21e75a8191d): <https://commits.webkit.org/288490@main>
Reviewed commits have been landed. Closing PR #38578 and removing active labels.
EWS
Committed 288871@main (c27ba7a1cf4d): <https://commits.webkit.org/288871@main>
Reviewed commits have been landed. Closing PR #38571 and removing active labels.