Bug 285379
| Summary: | Create WebKitWebExtension API for WebKitGTk | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jamie Murphy <jmurphy> |
| Component: | WebKitGTK | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, commit-queue, dpino |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 288481, 288484 | ||
| Bug Blocks: | 288478 | ||
Jamie Murphy
This API exposes WebExtension manifest support. At the moment, there's no Context or Controller API to use this yet, the only APIs provided are regarding parsing manifest information.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Jamie Murphy
Pull request: https://github.com/WebKit/WebKit/pull/38527
EWS
Committed 290957@main (785a4e3b033d): <https://commits.webkit.org/290957@main>
Reviewed commits have been landed. Closing PR #38527 and removing active labels.
WebKit Commit Bot
Re-opened since this is blocked by bug 288481
Jamie Murphy
Pull request: https://github.com/WebKit/WebKit/pull/49408
EWS
Committed 301078@main (68f61154cacb): <https://commits.webkit.org/301078@main>
Reviewed commits have been landed. Closing PR #49408 and removing active labels.
Diego Pino
Changeset broke WebKitGTK build with GTK3 (`--cmakeargs=-DUSE_GTK4=OFF`). The build error is:
https://build.webkit.org/#/builders/1519/builds/7515/steps/10/logs/stdio
```
worker/GTK-Linux-64-bit-Release-GTK3-Build/build/WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/webkit/WebKitEnumTypes.cpp/home/buildbot-worker/GTK-Linux-64-bit-Release-GTK3-Build/build/WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/webkit/WebKitEnumTypes.cpp: In function ‘GType webkit_web_extension_match_pattern_options_get_type()’:/home/buildbot-worker/GTK-Linux-64-bit-Release-GTK3-Build/build/WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/webkit/WebKitEnumTypes.cpp:641:11: error: ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_NONE’ was not declared in this scope; did you mean ‘WEBKIT_TYPE_WEB_EXTENSION_MATCH_PATTERN_OPTIONS’? 641 | { WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_NONE, "WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_NONE", "none" }, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | WEBKIT_TYPE_WEB_EXTENSION_MATCH_PATTERN_OPTIONS/home/buildbot-worker/GTK-Linux-64-bit-Release-GTK3-Build/build/WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/webkit/WebKitEnumTypes.cpp:642:11: error: ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_SCHEMES’ was not declared in this scope; did you mean ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_ERROR_INVALID_SCHEME’? 642 | { WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_SCHEMES, "WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_SCHEMES", "ignore-schemes" }, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | WEBKIT_WEB_EXTENSION_MATCH_PATTERN_ERROR_INVALID_SCHEME/home/buildbot-worker/GTK-Linux-64-bit-Release-GTK3-Build/build/WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/webkit/WebKitEnumTypes.cpp:643:11: error: ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_PATHS’ was not declared in this scope; did you mean ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_ERROR_INVALID_PATH’? 643 | { WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_PATHS, "WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_IGNORE_PATHS", "ignore-paths" }, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | WEBKIT_WEB_EXTENSION_MATCH_PATTERN_ERROR_INVALID_PATH/home/buildbot-worker/GTK-Linux-64-bit-Release-GTK3-Build/build/WebKitBuild/GTK/Release/WebKitGTK/DerivedSources/webkit/WebKitEnumTypes.cpp:644:11: error: ‘WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_MATCH_BIDIRECTIONALLY’ was not declared in this scope 644 | { WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_MATCH_BIDIRECTIONALLY, "WEBKIT_WEB_EXTENSION_MATCH_PATTERN_OPTIONS_MATCH_BIDIRECTIONALLY", "match-bidirectionally" }, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
Diego Pino
Re-opening for pull request https://github.com/WebKit/WebKit/pull/51993
EWS
Committed 301195@main (8a6a6600d5d2): <https://commits.webkit.org/301195@main>
Reviewed commits have been landed. Closing PR #51993 and removing active labels.
Diego Pino
Re-opening for pull request https://github.com/WebKit/WebKit/pull/52007
EWS
Committed 301205@main (0e5a6487523b): <https://commits.webkit.org/301205@main>
Reviewed commits have been landed. Closing PR #52007 and removing active labels.