Bug 285094
| Summary: | AutoInstall.find_spec doesn't return a spec | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
| Component: | Tools / Tests | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari 16 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 284088 | ||
Sam Sneddon [:gsnedders]
Currently we return a module-or-None:
https://github.com/WebKit/WebKit/blob/31f53890413ab604b438db03c40f219b25f3ced1/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py#L700
Well, it's also unclear what the semantics of Loader.create_module(spec=None) is meant to be, but experimentally SourceFileLoader.create_module always returns none.
This means that we always fall into the "If a spec cannot be found, None is returned", so our MetaPathFinder never actually finds anything (though it has side-effects, insofar as packages do get installed).
It also means all the complex logic is for nothing, because all we're actually doing is returning None.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Sneddon [:gsnedders]
Pull request: https://github.com/WebKit/WebKit/pull/38332
Radar WebKit Bug Importer
<rdar://problem/142167006>
EWS
Committed 288677@main (810335aedc77): <https://commits.webkit.org/288677@main>
Reviewed commits have been landed. Closing PR #38332 and removing active labels.