Bug 284933
| Summary: | Avoid churning Style::Colors via colorResolvingCurrentColor() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | CSS | Assignee: | Simon Fraser (smfr) <simon.fraser> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | koivisto, m_dubet, sam, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Simon Fraser (smfr)
Style::Color can be expensive to create and destroy because of the std::variant overhead.
We can avoid having RenderStyle::unresolvedColorForProperty return a copy.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/141729996>
Simon Fraser (smfr)
Pull request: https://github.com/WebKit/WebKit/pull/38189
EWS
Committed 288099@main (89e7ad233911): <https://commits.webkit.org/288099@main>
Reviewed commits have been landed. Closing PR #38189 and removing active labels.