Bug 28483

Summary:

[V8] ScriptController::cleanupScriptObjectsForPlugin should take a Widget* instead of void*

Product:

WebKit

Reporter:

Darin Fisher (:fishd, Google) <fishd>

Component:

WebCore JavaScript

Assignee:

Darin Fisher (:fishd, Google) <fishd>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
v1 patch	eric: review+

Darin Fisher (:fishd, Google)

Reported 2009-08-19 23:00:02 PDT

[V8] ScriptController::cleanupScriptObjectsForPlugin should take a Widget* instead of void* This function is supposed to be called by the plugin when it goes away. It corresponds to createScriptInstanceForWidget, which takes a Widget*. As is, it is important for callers to cast to Widget* before calling cleanupScriptObjectsForPlugin, which is rather error prone. See http://codereview.chromium.org/174126 for example.

Attachments
v1 patch (2.35 KB, patch) 2009-08-20 00:10 PDT, Darin Fisher (:fishd, Google)	eric: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Darin Fisher (:fishd, Google)

Comment 1 2009-08-20 00:10:01 PDT

Created attachment 35188 [details] v1 patch

Eric Seidel (no email)

Comment 2 2009-08-20 00:19:30 PDT

Comment on attachment 35188 [details] v1 patch LGTM.

Darin Fisher (:fishd, Google)

Comment 3 2009-08-20 00:31:48 PDT

Landed as: http://trac.webkit.org/changeset/47556

Note You need to log in before you can comment on or make changes to this bug.