Bug 284780
| Summary: | [JSC] Remove stack height check for JSString::resolveToBuffer since we are using tail-calls | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> |
| Component: | JavaScriptCore | Assignee: | Yusuke Suzuki <ysuzuki> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | fujii.hironori, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Yusuke Suzuki
...
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/141567781>
Yusuke Suzuki
Pull request: https://github.com/WebKit/WebKit/pull/38036
EWS
Committed 287916@main (f941f5ebc01f): <https://commits.webkit.org/287916@main>
Reviewed commits have been landed. Closing PR #38036 and removing active labels.
Fujii Hironori
Windows port is crashing after this change.
https://build.webkit.org/results/Windows-64-bit-Release-Tests/287926@main%20(1906)/results.html
bug#283320 has disabled MUST_TAIL_CALL for Windows port.
What should Windows port do?
Yusuke Suzuki
@Fujii Call `JSRopeString::resolveToBufferSlow` for all cases in resolveToBuffer. It can always handle things.
Please keep the current thing as is for the other platforms. This is really important optimizations for, in particular, macOS / iOS x64 / ARM64.
Fujii Hironori
Thank you very much for the advice. I'm going to fix it in bug#284809.