Bug 284738
| Summary: | [WebDriver][socket] true is set even if the acceptInsecureCerts is false | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | haruhisa.shin <haruhisa.shin> |
| Component: | WebDriver | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bburg, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
haruhisa.shin
There was a mistake in https://commits.webkit.org/287707@main .
> if (capabilitiesObject && capabilitiesObject->getBoolean("acceptInsecureCerts"_s))
> capabilities.acceptInsecureCertificates = true;
The JSONObject::getBoolean() returns std::optional<bool>, not bool.
So the above code would set variable acceptInsecureCertificates to true even if the JSON value is false.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
haruhisa.shin
Pull request: https://github.com/WebKit/WebKit/pull/38002
EWS
Committed 287873@main (6572975a5c6e): <https://commits.webkit.org/287873@main>
Reviewed commits have been landed. Closing PR #38002 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/141538899>