Bug 28464

Summary:

Sound button appears in controller with movies that have no audio

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

scherkus

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
proposed patch	eric: review+, eric: commit-queue-

Eric Carlson

Reported 2009-08-19 10:25:22 PDT

Movie controller audio button appears and accepts clicks for movies that have no audio. The control has no use, so we should just remove it when a movie has no audio.

Attachments
proposed patch (21.23 KB, patch) 2009-08-19 10:26 PDT, Eric Carlson	eric: review+ eric: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Carlson

Comment 1 2009-08-19 10:25:38 PDT

<rdar://problem/6102883>

Eric Carlson

Comment 2 2009-08-19 10:26:47 PDT

Created attachment 35128 [details] proposed patch

Eric Seidel (no email)

Comment 3 2009-08-19 10:46:52 PDT

Comment on attachment 35128 [details] proposed patch Looks fine. You're a committer, so setting cq-. You can set cq+ if you'd rather the bot build, test and commit this for you.

Eric Carlson

Comment 4 2009-08-19 11:11:53 PDT

http://trac.webkit.org/changeset/47515

Eric Carlson

Comment 5 2009-08-21 08:54:49 PDT

*** Bug 23408 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.