Bug 28464 - Sound button appears in controller with movies that have no audio
Summary: Sound button appears in controller with movies that have no audio
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 23408 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-08-19 10:25 PDT by Eric Carlson
Modified: 2009-08-21 08:54 PDT (History)
1 user (show)

See Also:


Attachments
proposed patch (21.23 KB, patch)
2009-08-19 10:26 PDT, Eric Carlson
eric: review+
eric: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2009-08-19 10:25:22 PDT
Movie controller audio button appears and accepts clicks for movies that have no audio. The control has no use, so we should just remove it when a movie has no audio.
Comment 1 Eric Carlson 2009-08-19 10:25:38 PDT
<rdar://problem/6102883>
Comment 2 Eric Carlson 2009-08-19 10:26:47 PDT
Created attachment 35128 [details]
proposed patch
Comment 3 Eric Seidel (no email) 2009-08-19 10:46:52 PDT
Comment on attachment 35128 [details]
proposed patch

Looks fine.  You're a committer, so setting cq-.  You can set cq+ if you'd rather the bot build, test and commit this for you.
Comment 4 Eric Carlson 2009-08-19 11:11:53 PDT
http://trac.webkit.org/changeset/47515
Comment 5 Eric Carlson 2009-08-21 08:54:49 PDT
*** Bug 23408 has been marked as a duplicate of this bug. ***