Bug 28462

Summary: WebCore causes linker warnings on Windows about multiply-defined JSHTMLDataListElement symbols
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Windows XP   
Attachments:
Description Flags
Patch v1 andersca: review+

Description Adam Roben (:aroben) 2009-08-19 10:10:41 PDT
Created attachment 35127 [details]
Patch v1

Reviewed by NOBODY (OOPS!).

Need a short description and bug URL (OOPS!)

* WebCore.vcproj/WebCore.vcproj: Exclude JSHTMLDataListElement.cpp
from the build (just like we do for the other generated bindings
files) so that we don't get warnings about multiply-defined symbols in
JSHTMLDataListElement.cpp and DerivedSources.cpp. Also removed
duplicate versions of JSSVGElementWrapperFactory.cpp, and let VS
reorder a few files.
---
 2 files changed, 59 insertions(+), 92 deletions(-)
Comment 1 Anders Carlsson 2009-08-19 10:12:28 PDT
Comment on attachment 35127 [details]
Patch v1

r=me
Comment 2 Adam Roben (:aroben) 2009-08-19 10:15:47 PDT
Committed r47508: http://trac.webkit.org/changeset/47508