Bug 28459

Summary: bugzilla-tool needs a new name
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Adam's requested proof-of-concept of adding a clone tool with the same name.
none
Patch eric: review+

Description Eric Seidel (no email) 2009-08-19 09:50:52 PDT
bugzilla-tool needs a new name

If we can come up with a name here, I'm happy to make it happen.  I've got a few out-standing patches against the current tool, so I'd like to move those/land those before we land the rename though.

webkit-tool
wkt
kitchen-sink?
Comment 1 Adam Barth 2009-08-19 10:54:51 PDT
patch-tool
Comment 2 Adam Barth 2010-01-04 03:20:54 PST
*** Bug 33129 has been marked as a duplicate of this bug. ***
Comment 3 Eric Seidel (no email) 2010-01-04 15:12:44 PST
I thought about naming more this morning.  I like Maciej/Adam's proposal to rename bzt to webkit-patch.  But one remaining question is where do we stuff all the other commands which don't fit that model.  Also, implied in that rename is that commands should combine to form smarter verb-named commands.  Like "apply-patches" and "apply-attachment" combining to just "apply" with some flags to enable the less-common usages.

All of the bugzilla-tool commands currently marked "common" are patch related, except tree-status:
apply-attachment, apply-patches, land-attachment, land-diff, land-patches, post-commits, post-diff, rollout, tree-status
Comment 4 Adam Barth 2010-01-04 17:01:55 PST
I'm fine with demoting tree-status for the main list of commands.
Comment 5 Eric Seidel (no email) 2010-01-04 17:03:30 PST
Adam and I talked a bit offline about making a new "webkit-patch" tool and slowly moving commands over to there when they're "ready for primetime.  bugzilla-tool (renamed or otherwise) could stick around for the while as the kitchen-sink (the tool which includes all the commands).
Comment 6 Eric Seidel (no email) 2010-01-05 16:21:29 PST
Created attachment 45937 [details]
Adam's requested proof-of-concept of adding a clone tool with the same name.
Comment 7 WebKit Review Bot 2010-01-05 16:22:13 PST
style-queue ran check-webkit-style on attachment 45937 [details] without any errors.
Comment 8 Eric Seidel (no email) 2010-01-05 16:23:38 PST
Comment on attachment 45937 [details]
Adam's requested proof-of-concept of adding a clone tool with the same name.

Forgot to pass --no-review.

I think I'm OK with just renaming bugzilla-tool to webkit-patch.  Yes, it sucks that webkit-patch will have a bunch of unrelated crap in it.  Yes, people will get confused about what bugzilla-tool is called.  Yes, we'll have to re-start all of our scripts.  But I'm less and less sure that having separate tools buys us much.  We could continue down the path of this patch, and with only a little more code restrict the commands which are exposed under webkit-patch.  But I'm not sure it buys us much.
Comment 9 Adam Barth 2010-01-07 00:34:11 PST
Created attachment 46029 [details]
Patch
Comment 10 Eric Seidel (no email) 2010-01-07 00:40:56 PST
Comment on attachment 46029 [details]
Patch

-from-bug was a nice touch.

for another bug: I think we should kill the optional [BUGID] on commands like land-diff (now "land") because they shouldn't be needed now that we can parse bug ids from ChangeLogs.

We could rename "tree status" to "may-I-land" or something similar. :)

Is Upload not yet a strict super-set of post?  Would be nice to kill post eventually.

Seems prepare and post don't actually need to be in the main help now that we have the new hotness we call upload.

Looks good.  Seems we should send an email to webkit-dev mentioning the rename.  We can just point people to --help if it's too complicated to explain.