Summary: | <canvas> createImageData doesn't handle negative values properly | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | George Wright <gwright> | ||||||
Component: | WebCore Misc. | Assignee: | George Wright <gwright> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | darin, kling | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
URL: | http://philip.html5.org/tests/canvas/suite/tests/2d.imageData.create.negative.html | ||||||||
Attachments: |
|
Description
George Wright
2009-08-19 08:11:52 PDT
Created attachment 35122 [details]
Handle negatives properly
Proposed fix for this bug.
Created attachment 35125 [details]
Include layout tests
Woops, old patch didn't include the layout tests for some reason.
Comment on attachment 35125 [details]
Include layout tests
Seems that this test should be a dumpAsText cross-platform test, the way many of the tests in fast/canvas are, such as canvas-alphaImageData-behavior.html for example. That would be more valuable than one with platform-specific results.
r=me as is, but please consider making that change
Comment on attachment 35125 [details]
Include layout tests
Since George isn't a committer and won't be able to commit this when landing, marking this r- per Darin's above comments. I agree, this would be nicer as a dumpAsText test.
I fixed this with http://trac.webkit.org/changeset/59613 (bug 39189) |