Bug 284504
| Summary: | Remove Quirk needsIPadMiniUserAgent for tv.kakao.com | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Karl Dubost <karlcow> |
| Component: | WebKit Misc. | Assignee: | Karl Dubost <karlcow> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://tv.kakao.com/ | ||
| Bug Depends on: | 198484 | ||
| Bug Blocks: | |||
Karl Dubost
Currently on regular iPad, tv.kakao.com is receiving iPad Mini User Agent instead of the traditional desktop user agent.
Initially this Quirk was added through Bug 198484 on 2019-06-04
https://github.com/WebKit/WebKit/commit/4bb8f0f34179bd8ed4dcafeda205f65b5b8d6c87#diff-d2eb30e968da05615b61df7746f0d13b708da1629b083d455e1f98de80367bebR1293-R1295
then moved later on to
https://github.com/WebKit/WebKit/blob/ba1fbaadee0af044adad5a31c2eca663007c44b2/Source/WebCore/page/Quirks.cpp#L1677
The reason for adding it is at the time this site is that receiving the desktop UA, some sites were sending the Flash Player to the users which was not supported on iOS devices.
The Flah player end of life was programmed for 2020.
This needs to be tested with Quirks disabled. If the site is working without the iPad Mini UA, then we can remove this quirk.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/141330961>
Karl Dubost
With the iPad Mini UA override, https://tv.kakao.com/ redirects to https://tv.kakao.com/m
When accessing tv.kakao.com with a desktop UA on iPad (and Cookies, Cache empty, etc.), the site proposes the desktop layout but also an alert in Korean, which says:
Would you like to move to a page optimized for the device environment
(tablet) you are currently using?
Cancel Move
We can probably remove the Quirk as the choice is proposed to the users.
Karl Dubost
Pull request: https://github.com/WebKit/WebKit/pull/37816
EWS
Committed 287727@main (822d4788ed04): <https://commits.webkit.org/287727@main>
Reviewed commits have been landed. Closing PR #37816 and removing active labels.