Bug 284480

Summary: Remove unreachable code from Python tools
Product: WebKit Reporter: Sam Sneddon [:gsnedders] <gsnedders>
Component: Tools / TestsAssignee: Sam Sneddon [:gsnedders] <gsnedders>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Sam Sneddon [:gsnedders]
Reported 2024-12-11 12:42:37 PST
https://commits.webkit.org/287424@main accidentally left some dead code from ruff's UP036 fixer. For example: ``` @classmethod def gmtoffset(cls): - if sys.version_info >= (3, 0): - return int(time.localtime().tm_gmtoff * 100 / (60 * 60)) + return int(time.localtime().tm_gmtoff * 100 / (60 * 60)) ts = time.time() return int((datetime.fromtimestamp(ts) - datetime.utcfromtimestamp(ts)).total_seconds() * 100 / (60 * 60)) ```
Attachments
Sam Sneddon [:gsnedders]
Comment 1 2024-12-11 12:53:09 PST
EWS
Comment 2 2024-12-11 13:19:16 PST
Committed 287692@main (b7a2c9869a47): <https://commits.webkit.org/287692@main> Reviewed commits have been landed. Closing PR #37791 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2024-12-11 13:20:15 PST
Note You need to log in before you can comment on or make changes to this bug.