Bug 284478
Summary: | [AutoInstall] Always uses pypi.org, ignores pip.conf | ||
---|---|---|---|
Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=275332 |
Sam Sneddon [:gsnedders]
webkitcorepy.autoinstall has:
```python
def _default_pypi_index():
return 'pypi.org'
pypi_url = re.compile(r'\Aindex\S* = https?://(?P<host>\S+)/.*')
pip_config = '/Library/Application Support/pip/pip.conf'
if os.path.isfile(pip_config):
with open(pip_config, 'r') as config:
for line in config.readlines():
match = pypi_url.match(line.lstrip())
if match:
return match.group('host')
return 'pypi.org'
```
Fairly obviously, everything after the initial return is dead code.
Behaviour here changed in https://github.com/WebKit/WebKit/commit/3f8cbc3426c78930f3b7238372e6e1a953864549 (bug 275332), but neither the commit message nor the PR nor the bug give any evidence as to why this change was made. I presume it might be accidentally from during development?
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/141306004>
Jonathan Bedard
This was not deliberate, posting a fix now.
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/37790
EWS
Committed 287704@main (f7e269f60320): <https://commits.webkit.org/287704@main>
Reviewed commits have been landed. Closing PR #37790 and removing active labels.