Bug 284470
| Summary: | Web Automation: modernize callback thunks for async protocol commands | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Blaze Burg <bburg> |
| Component: | WebDriver | Assignee: | Blaze Burg <bburg> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bburg, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | |||
| Bug Blocks: | 289259 | ||
Blaze Burg
We need to be able to connect async WebAutomationSession/WebAutomationBidiProcessor methods to each other. Right now these callbacks are all BackendDispatcher::CallbackBase subclasses, which does not have a standalone constructor. So, we cannot easily pass a lambda that chains completion handlers.
In order to chain callbacks, switch from using CallbackBase subclasses to using Function<> with proper type parameters.
NB. We may consider using CompletionHandlers in some places, but for now the types are expressed using the less strict Function template.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/141291944>
Blaze Burg
Pull request: https://github.com/WebKit/WebKit/pull/41067
EWS
Committed 291284@main (9e1b4bc5f110): <https://commits.webkit.org/291284@main>
Reviewed commits have been landed. Closing PR #41067 and removing active labels.