Bug 284257

Summary:	Cleanup unnecessary duplicated "visitorAdditionalChildren" methods in Observable code
Product:	WebKit	Reporter:	Marais Rossouw <me>
Component:	DOM	Assignee:	Marais Rossouw <me>
Status:	RESOLVED FIXED
Severity:	Trivial	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	All
OS:	All

Marais Rossouw

Reported 2024-12-08 18:25:58 PST

We have a method called "visitorAdditionalChildren" on our base InternalObserver class, which requires implementations for both AbstractSlotVisitor, and SlotVisitor. This is not required, as AbstractSlotVisitor is a base class to SlotVisitor — so we only need one.

Attachments
Add attachment proposed patch, testcase, etc.

Marais Rossouw

Comment 1 2024-12-08 18:33:09 PST

Pull request: https://github.com/WebKit/WebKit/pull/37610

EWS

Comment 2 2024-12-09 07:15:17 PST

Committed 287546@main (d2eb155406a3): <https://commits.webkit.org/287546@main> Reviewed commits have been landed. Closing PR #37610 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2024-12-09 07:16:16 PST

<rdar://problem/141155142>

Note You need to log in before you can comment on or make changes to this bug.