Bug 284079
| Summary: | Add a check-webkit-style to prevent merging unchanneled log (WTF_LOG_ALWAYS/WTFLogAlways) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Matthieu Dubet <m_dubet> |
| Component: | Tools / Tests | Assignee: | Matthieu Dubet <m_dubet> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Matthieu Dubet
We regularly commit those by mistake. It should never happen.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Simon Fraser (smfr)
WTFLogAlwas, ALWAYS_LOG_WITH_STREAM, WTF_ALWAYS_LOG
Maybe fprintf({stdout, stderr}, /printf/NSLog too?
Simon Fraser (smfr)
^ WTFLogAlways, ALWAYS_LOG_WITH_STREAM, WTF_ALWAYS_LOG
Matthieu Dubet
Pull request: https://github.com/WebKit/WebKit/pull/37490
EWS
Committed 287412@main (5ac8f6af64f9): <https://commits.webkit.org/287412@main>
Reviewed commits have been landed. Closing PR #37490 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/141013086>