Bug 28407

Summary:

No, silly runtime, AST nodes are not for you.

Product:

WebKit

Reporter:

Gavin Barraclough <barraclough>

Component:

JavaScriptCore

Assignee:

Gavin Barraclough <barraclough>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
The Patch	sam: review+

Description Gavin Barraclough 2009-08-17 13:03:12 PDT

We still use AST nodes (ScopeNodes, particularly FunctionBodyNodes) within the runtime, which means that these nodes must be persisted outside of the arena, contain both parser & runtime data, etc.  This is all a bit of a mess.  Move functionality into a new FunctionExecutable class.

Comment 1 Gavin Barraclough 2009-08-17 13:09:49 PDT

Created attachment 34988 [details]
The Patch

Comment 2 Gavin Barraclough 2009-08-17 22:43:28 PDT

Transmitting file data ..........................................
Committed revision 47412.
Transmitting file data .
Committed revision 47413.

Comment 3 Gavin Barraclough 2009-08-17 22:43:40 PDT

Transmitting file data ..........................................
Committed revision 47412.
Transmitting file data .
Committed revision 47413.