Bug 28407

Summary: No, silly runtime, AST nodes are not for you.
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
The Patch sam: review+

Gavin Barraclough
Reported 2009-08-17 13:03:12 PDT
We still use AST nodes (ScopeNodes, particularly FunctionBodyNodes) within the runtime, which means that these nodes must be persisted outside of the arena, contain both parser & runtime data, etc. This is all a bit of a mess. Move functionality into a new FunctionExecutable class.
Attachments
The Patch (125.57 KB, patch)
2009-08-17 13:09 PDT, Gavin Barraclough 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2009-08-17 13:09:49 PDT
Created attachment 34988 [details] The Patch
Gavin Barraclough
Comment 2 2009-08-17 22:43:28 PDT
Transmitting file data .......................................... Committed revision 47412. Transmitting file data . Committed revision 47413.
Gavin Barraclough
Comment 3 2009-08-17 22:43:40 PDT
Transmitting file data .......................................... Committed revision 47412. Transmitting file data . Committed revision 47413.
Note You need to log in before you can comment on or make changes to this bug.