Bug 283941
| Summary: | [WASM] Default-initialized fields of WASM GC struct should use Const32 if appropriate for storage type | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Degazio <d_degazio> |
| Component: | WebAssembly | Assignee: | David Degazio <d_degazio> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | fufuyqqqqqq, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | All | ||
David Degazio
rdar://140773922
Currently in OMG, for struct.new_default, we either store a JSNull for reference fields, or a Const64(0) for all other fields. This makes the B3 validator unhappy if the field is an i8, i16, or i32, because for those smaller stores, it expects a Const32 value. We should emit a Const32 if appropriate to abide by the B3 type system, even if the semantics and runtime behavior are essentially identical.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Degazio
*** Bug 283888 has been marked as a duplicate of this bug. ***
David Degazio
Pull request: https://github.com/WebKit/WebKit/pull/37347
EWS
Committed 287295@main (a9abb749d5da): <https://commits.webkit.org/287295@main>
Reviewed commits have been landed. Closing PR #37347 and removing active labels.