Bug 28394

Summary:

[Chromium] Implement and upstream WebKit API for the Chromium port

Product:

WebKit

Reporter:

Dimitri Glazkov (Google) <dglazkov>

Component:

Tools / Tests

Assignee:

Darin Fisher (:fishd, Google) <fishd>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

31276

Bug Blocks:

28395, 28396

Attachments:

Description	Flags
public/WebA*.h + ChangeLog	dglazkov: review+
WebNode and Friends.	none
WebBindings.h through WebColor.h	dglazkov: review+
More WebC*.h files	dglazkov: review+
Last of the WebC*.h files	dglazkov: review+
WebData*.h	dglazkov: review+
Upstreaming WebVector ... WebWorkerClient	none
WebURL and friends	none
WebText and Friends	none
WebString and other basic objects.	none
WebSockets and WebStorage.	none
WebScreenInfo to WebSharedWorkerRepo	none
WebDevTools.h & WebDrag.h	dglazkov: review+
Remainder of WebE.h and WebF.h	dglazkov: review+
WebH.h and WebI.h	dglazkov: review+
WebKit.h through WebMedia*.h	dglazkov: review+
WebMessage.h through WebNavigation.h	dglazkov: review+
Rest of WebN*.h	dglazkov: review+
2009-11-09 Nate Chapin <japhet@chromium.org>	none
Upstreaming Chromium API src files: WebAccessibility	none
WebPa.h and WebPl.h	none
WebPo*.h and WebRuntimeFeatures.h	none
Upstreaming Chromium API: Platform specific files	none

Description Dimitri Glazkov (Google) 2009-08-17 10:23:56 PDT

This is a master bug for finishing and upstreaming the WebKit API layer for the Chromium port. This will live in WebKit/chromium:

http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/

Comment 1 Nate Chapin 2009-11-09 10:39:30 PST

Created attachment 42764 [details]
public/WebA*.h + ChangeLog

Comment 2 Dimitri Glazkov (Google) 2009-11-09 10:40:55 PST

Comment on attachment 42764 [details]
public/WebA*.h + ChangeLog

yay!

Comment 3 Yaar Schnitman 2009-11-09 10:59:12 PST

Created attachment 42767 [details]
WebNode and Friends.

Comment 4 Nate Chapin 2009-11-09 11:02:07 PST

Created attachment 42769 [details]
WebBindings.h through WebColor.h

Comment 5 Dimitri Glazkov (Google) 2009-11-09 11:02:21 PST

Comment on attachment 42767 [details]
WebNode and Friends.

r=me.

Comment 6 Dimitri Glazkov (Google) 2009-11-09 11:03:50 PST

Comment on attachment 42769 [details]
WebBindings.h through WebColor.h

r=me.

Comment 7 WebKit Commit Bot 2009-11-09 11:18:50 PST

Comment on attachment 42767 [details]
WebNode and Friends.

Clearing flags on attachment: 42767

Committed r50669: <http://trac.webkit.org/changeset/50669>

Comment 8 WebKit Commit Bot 2009-11-09 11:18:54 PST

All reviewed patches have been landed.  Closing bug.

Comment 9 Dimitri Glazkov (Google) 2009-11-09 11:22:26 PST

bad bot. no biscuit.

Comment 10 Nate Chapin 2009-11-09 11:23:45 PST

Created attachment 42773 [details]
More WebC*.h files

Comment 11 Dimitri Glazkov (Google) 2009-11-09 11:26:11 PST

Comment on attachment 42773 [details]
More WebC*.h files

r=me.

Comment 12 Nate Chapin 2009-11-09 11:42:51 PST

Created attachment 42775 [details]
Last of the WebC*.h files

Comment 13 Nate Chapin 2009-11-09 12:13:10 PST

Created attachment 42777 [details]
WebData*.h

Comment 14 Yaar Schnitman 2009-11-09 12:24:19 PST

Created attachment 42778 [details]
Upstreaming WebVector ... WebWorkerClient

Comment 15 Yaar Schnitman 2009-11-09 12:30:02 PST

Created attachment 42780 [details]
WebURL and friends

Comment 16 Dimitri Glazkov (Google) 2009-11-09 12:32:58 PST

Comment on attachment 42775 [details]
Last of the WebC*.h files

r=me.

Comment 17 Yaar Schnitman 2009-11-09 12:33:40 PST

Created attachment 42781 [details]
WebText and Friends

Comment 18 Dimitri Glazkov (Google) 2009-11-09 12:34:12 PST

Comment on attachment 42777 [details]
WebData*.h

r=me.

Comment 19 Yaar Schnitman 2009-11-09 12:36:26 PST

Created attachment 42783 [details]
WebString and other basic objects.

Comment 20 Yaar Schnitman 2009-11-09 12:40:30 PST

Created attachment 42784 [details]
WebSockets and WebStorage.

Comment 21 Yaar Schnitman 2009-11-09 12:44:04 PST

Created attachment 42785 [details]
WebScreenInfo to WebSharedWorkerRepo

Comment 22 Dimitri Glazkov (Google) 2009-11-09 12:44:57 PST

Comment on attachment 42778 [details]
Upstreaming WebVector ... WebWorkerClient

r=me.

Comment 23 Dimitri Glazkov (Google) 2009-11-09 12:47:49 PST

Comment on attachment 42780 [details]
WebURL and friends

r=me.

Comment 24 Nate Chapin 2009-11-09 13:04:21 PST

Created attachment 42787 [details]
WebDevTools*.h & WebDrag*.h

Comment 25 WebKit Commit Bot 2009-11-09 13:06:53 PST

Comment on attachment 42778 [details]
Upstreaming WebVector ... WebWorkerClient

Clearing flags on attachment: 42778

Committed r50681: <http://trac.webkit.org/changeset/50681>

Comment 26 Eric Seidel (no email) 2009-11-09 13:07:56 PST

Comment on attachment 42781 [details]
WebText and Friends

Looks OK.

Comment 27 Dimitri Glazkov (Google) 2009-11-09 13:08:30 PST

Comment on attachment 42781 [details]
WebText and Friends

r=me.

Comment 28 Eric Seidel (no email) 2009-11-09 13:09:12 PST

Comment on attachment 42784 [details]
WebSockets and WebStorage.

Looks OK.

Comment 29 Dimitri Glazkov (Google) 2009-11-09 13:11:15 PST

Comment on attachment 42787 [details]
WebDevTools*.h & WebDrag*.h

r=me.

Comment 30 Eric Seidel (no email) 2009-11-09 13:12:48 PST

Comment on attachment 42787 [details]
WebDevTools*.h & WebDrag*.h

There are some named args here which don't need them:
+    WEBKIT_API static WebDevToolsFrontend* create(WebView* view,
+                                                  WebDevToolsFrontendClient* client,

I'm not a huge fan of the WEBKIT_IMPLEMENTATION approach, but we should discuss that more after this all lands.

Looks good.

Comment 31 WebKit Commit Bot 2009-11-09 13:14:26 PST

Comment on attachment 42780 [details]
WebURL and friends

Clearing flags on attachment: 42780

Committed r50682: <http://trac.webkit.org/changeset/50682>

Comment 32 WebKit Commit Bot 2009-11-09 13:14:33 PST

All reviewed patches have been landed.  Closing bug.

Comment 33 Eric Seidel (no email) 2009-11-09 13:17:00 PST

The closing is caused by bug 28230.

Comment 34 Nate Chapin 2009-11-09 13:17:26 PST

Created attachment 42794 [details]
Remainder of WebE*.h and WebF*.h

Comment 35 Eric Seidel (no email) 2009-11-09 13:18:47 PST

Dimitri might as well review the last patch before we re-open the bug.  Once it's reopened, the cq will start on it again and will close it when completed.

The cq only grabs the list of patches at the start of its run.  It's not smart enough to check to see if more patches were added by the time it is done landing the first one.  It's just not really designed with multi-patch bugs in mind.

Comment 36 Dimitri Glazkov (Google) 2009-11-09 13:19:47 PST

Comment on attachment 42794 [details]
Remainder of WebE*.h and WebF*.h

r=me.

Comment 37 Dimitri Glazkov (Google) 2009-11-09 13:20:21 PST

we love cq.

Comment 38 Dimitri Glazkov (Google) 2009-11-09 13:25:19 PST

Comment on attachment 42785 [details]
WebScreenInfo to WebSharedWorkerRepo

r=me.

Comment 39 Dimitri Glazkov (Google) 2009-11-09 13:30:23 PST

Comment on attachment 42783 [details]
WebString and other basic objects.

r=me.

Comment 40 Nate Chapin 2009-11-09 13:39:50 PST

Created attachment 42797 [details]
WebH*.h and WebI*.h

Comment 41 WebKit Commit Bot 2009-11-09 13:40:09 PST

Comment on attachment 42781 [details]
WebText and Friends

Clearing flags on attachment: 42781

Committed r50686: <http://trac.webkit.org/changeset/50686>

Comment 42 Dimitri Glazkov (Google) 2009-11-09 13:44:13 PST

Comment on attachment 42797 [details]
WebH*.h and WebI*.h

r=me.

Comment 43 WebKit Commit Bot 2009-11-09 13:47:41 PST

Comment on attachment 42783 [details]
WebString and other basic objects.

Clearing flags on attachment: 42783

Committed r50687: <http://trac.webkit.org/changeset/50687>

Comment 44 WebKit Commit Bot 2009-11-09 13:55:08 PST

Comment on attachment 42784 [details]
WebSockets and WebStorage.

Clearing flags on attachment: 42784

Committed r50688: <http://trac.webkit.org/changeset/50688>

Comment 45 Nate Chapin 2009-11-09 14:02:22 PST

Created attachment 42799 [details]
WebKit.h through WebMedia*.h

Comment 46 Dimitri Glazkov (Google) 2009-11-09 14:03:17 PST

Comment on attachment 42799 [details]
WebKit.h through WebMedia*.h

r=me.

Comment 47 WebKit Commit Bot 2009-11-09 14:19:46 PST

Comment on attachment 42785 [details]
WebScreenInfo to WebSharedWorkerRepo

Clearing flags on attachment: 42785

Committed r50692: <http://trac.webkit.org/changeset/50692>

Comment 48 WebKit Commit Bot 2009-11-09 14:19:53 PST

All reviewed patches have been landed.  Closing bug.

Comment 49 Nate Chapin 2009-11-09 14:22:07 PST

Created attachment 42801 [details]
WebMessage*.h through WebNavigation*.h

Comment 50 Nate Chapin 2009-11-09 14:24:07 PST

Created attachment 42802 [details]
Rest of WebN*.h

Comment 51 Dimitri Glazkov (Google) 2009-11-09 14:28:04 PST

Comment on attachment 42801 [details]
WebMessage*.h through WebNavigation*.h

r=me.

Comment 52 Dimitri Glazkov (Google) 2009-11-09 14:28:24 PST

cq rox0r.

Comment 53 Dimitri Glazkov (Google) 2009-11-09 14:29:14 PST

Comment on attachment 42802 [details]
Rest of WebN*.h

r=me.

Comment 54 Yaar Schnitman 2009-11-09 14:37:08 PST

Created attachment 42803 [details]
2009-11-09  Nate Chapin  <japhet@chromium.org>

Comment 55 Yaar Schnitman 2009-11-09 14:38:37 PST

Created attachment 42804 [details]
Upstreaming Chromium API src files: WebAccessibility

Comment 56 Nate Chapin 2009-11-09 14:58:10 PST

Created attachment 42805 [details]
WebPa*.h and WebPl*.h

Comment 57 Nate Chapin 2009-11-09 14:58:45 PST

Created attachment 42806 [details]
WebPo*.h and WebRuntimeFeatures.h

Comment 58 Yaar Schnitman 2009-11-09 17:38:49 PST

Created attachment 42815 [details]
Upstreaming Chromium API: Platform specific files

Comment 59 Dimitri Glazkov (Google) 2009-11-09 20:11:36 PST

Comment on attachment 42815 [details]
Upstreaming Chromium API: Platform specific files

r=me.

Comment 60 Dimitri Glazkov (Google) 2009-11-09 20:14:19 PST

Comment on attachment 42805 [details]
WebPa*.h and WebPl*.h

r=me.

Comment 61 WebKit Commit Bot 2009-11-09 20:25:27 PST

Comment on attachment 42815 [details]
Upstreaming Chromium API: Platform specific files

Clearing flags on attachment: 42815

Committed r50712: <http://trac.webkit.org/changeset/50712>

Comment 62 WebKit Commit Bot 2009-11-09 20:25:34 PST

All reviewed patches have been landed.  Closing bug.

Comment 63 Dimitri Glazkov (Google) 2009-11-09 20:27:43 PST

cq <3

Comment 64 WebKit Commit Bot 2009-11-09 20:58:35 PST

Comment on attachment 42805 [details]
WebPa*.h and WebPl*.h

Clearing flags on attachment: 42805

Committed r50716: <http://trac.webkit.org/changeset/50716>

Comment 65 WebKit Commit Bot 2009-11-09 21:06:02 PST

Comment on attachment 42806 [details]
WebPo*.h and WebRuntimeFeatures.h

Clearing flags on attachment: 42806

Committed r50717: <http://trac.webkit.org/changeset/50717>

Comment 66 WebKit Commit Bot 2009-11-09 21:06:09 PST

All reviewed patches have been landed.  Closing bug.