Bug 28394

Summary:

[Chromium] Implement and upstream WebKit API for the Chromium port

Product:

WebKit

Reporter:

Dimitri Glazkov (Google) <dglazkov>

Component:

Tools / Tests

Assignee:

Darin Fisher (:fishd, Google) <fishd>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

31276

Bug Blocks:

28395, 28396

Attachments:

Description	Flags
public/WebA*.h + ChangeLog	dglazkov: review+
WebNode and Friends.	none
WebBindings.h through WebColor.h	dglazkov: review+
More WebC*.h files	dglazkov: review+
Last of the WebC*.h files	dglazkov: review+
WebData*.h	dglazkov: review+
Upstreaming WebVector ... WebWorkerClient	none
WebURL and friends	none
WebText and Friends	none
WebString and other basic objects.	none
WebSockets and WebStorage.	none
WebScreenInfo to WebSharedWorkerRepo	none
WebDevTools.h & WebDrag.h	dglazkov: review+
Remainder of WebE.h and WebF.h	dglazkov: review+
WebH.h and WebI.h	dglazkov: review+
WebKit.h through WebMedia*.h	dglazkov: review+
WebMessage.h through WebNavigation.h	dglazkov: review+
Rest of WebN*.h	dglazkov: review+
2009-11-09 Nate Chapin <japhet@chromium.org>	none
Upstreaming Chromium API src files: WebAccessibility	none
WebPa.h and WebPl.h	none
WebPo*.h and WebRuntimeFeatures.h	none
Upstreaming Chromium API: Platform specific files	none

Dimitri Glazkov (Google)

Reported 2009-08-17 10:23:56 PDT

This is a master bug for finishing and upstreaming the WebKit API layer for the Chromium port. This will live in WebKit/chromium: http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/

Attachments
*public/WebA.h + ChangeLog** (19.54 KB, patch) 2009-11-09 10:39 PST, Nate Chapin	dglazkov: review+	Details Formatted Diff Diff
WebNode and Friends. (13.27 KB, patch) 2009-11-09 10:59 PST, Yaar Schnitman	no flags	Details Formatted Diff Diff
WebBindings.h through WebColor.h (17.74 KB, patch) 2009-11-09 11:02 PST, Nate Chapin	dglazkov: review+	Details Formatted Diff Diff
*More WebC.h files** (16.26 KB, patch) 2009-11-09 11:23 PST, Nate Chapin	dglazkov: review+	Details Formatted Diff Diff
*Last of the WebC.h files** (16.05 KB, patch) 2009-11-09 11:42 PST, Nate Chapin	dglazkov: review+	Details Formatted Diff Diff
*WebData.h** (14.56 KB, patch) 2009-11-09 12:13 PST, Nate Chapin	dglazkov: review+	Details Formatted Diff Diff
Upstreaming WebVector ... WebWorkerClient (44.43 KB, patch) 2009-11-09 12:24 PST, Yaar Schnitman	no flags	Details Formatted Diff Diff
WebURL and friends (24.60 KB, patch) 2009-11-09 12:30 PST, Yaar Schnitman	no flags	Details Formatted Diff Diff
WebText and Friends (4.94 KB, patch) 2009-11-09 12:33 PST, Yaar Schnitman	no flags	Details Formatted Diff Diff
WebString and other basic objects. (16.14 KB, patch) 2009-11-09 12:36 PST, Yaar Schnitman	no flags	Details Formatted Diff Diff
WebSockets and WebStorage. (17.95 KB, patch) 2009-11-09 12:40 PST, Yaar Schnitman	no flags	Details Formatted Diff Diff
WebScreenInfo to WebSharedWorkerRepo (30.06 KB, patch) 2009-11-09 12:44 PST, Yaar Schnitman	no flags	Details Formatted Diff Diff
*WebDevTools.h & WebDrag.h* (19.52 KB, patch) 2009-11-09 13:04 PST, Nate Chapin	dglazkov: review+	Details Formatted Diff Diff
*Remainder of WebE.h and WebF.h* (44.57 KB, patch) 2009-11-09 13:17 PST, Nate Chapin	dglazkov: review+	Details Formatted Diff Diff
*WebH.h and WebI.h* (25.67 KB, patch) 2009-11-09 13:39 PST, Nate Chapin	dglazkov: review+	Details Formatted Diff Diff
*WebKit.h through WebMedia.h** (26.73 KB, patch) 2009-11-09 14:02 PST, Nate Chapin	dglazkov: review+	Details Formatted Diff Diff
*WebMessage.h through WebNavigation.h* (13.44 KB, patch) 2009-11-09 14:22 PST, Nate Chapin	dglazkov: review+	Details Formatted Diff Diff
*Rest of WebN.h** (13.58 KB, patch) 2009-11-09 14:24 PST, Nate Chapin	dglazkov: review+	Details Formatted Diff Diff
2009-11-09 Nate Chapin <japhet@chromium.org> (19.49 KB, text/plain) 2009-11-09 14:37 PST, Yaar Schnitman	no flags	Details
Upstreaming Chromium API src files: WebAccessibility (25.66 KB, patch) 2009-11-09 14:38 PST, Yaar Schnitman	no flags	Details Formatted Diff Diff
*WebPa.h and WebPl.h* (19.53 KB, patch) 2009-11-09 14:58 PST, Nate Chapin	no flags	Details Formatted Diff Diff
*WebPo.h and WebRuntimeFeatures.h** (11.49 KB, patch) 2009-11-09 14:58 PST, Nate Chapin	no flags	Details Formatted Diff Diff
Upstreaming Chromium API: Platform specific files (30.68 KB, patch) 2009-11-09 17:38 PST, Yaar Schnitman	no flags	Details Formatted Diff Diff
Show Obsolete (14) View All Add attachment proposed patch, testcase, etc.

Nate Chapin

Comment 1 2009-11-09 10:39:30 PST

Created attachment 42764 [details] public/WebA*.h + ChangeLog

Dimitri Glazkov (Google)

Comment 2 2009-11-09 10:40:55 PST

Comment on attachment 42764 [details] public/WebA*.h + ChangeLog yay!

Yaar Schnitman

Comment 3 2009-11-09 10:59:12 PST

Created attachment 42767 [details] WebNode and Friends.

Nate Chapin

Comment 4 2009-11-09 11:02:07 PST

Created attachment 42769 [details] WebBindings.h through WebColor.h

Dimitri Glazkov (Google)

Comment 5 2009-11-09 11:02:21 PST

Comment on attachment 42767 [details] WebNode and Friends. r=me.

Dimitri Glazkov (Google)

Comment 6 2009-11-09 11:03:50 PST

Comment on attachment 42769 [details] WebBindings.h through WebColor.h r=me.

WebKit Commit Bot

Comment 7 2009-11-09 11:18:50 PST

Comment on attachment 42767 [details] WebNode and Friends. Clearing flags on attachment: 42767 Committed r50669: <http://trac.webkit.org/changeset/50669>

WebKit Commit Bot

Comment 8 2009-11-09 11:18:54 PST

All reviewed patches have been landed. Closing bug.

Dimitri Glazkov (Google)

Comment 9 2009-11-09 11:22:26 PST

bad bot. no biscuit.

Nate Chapin

Comment 10 2009-11-09 11:23:45 PST

Created attachment 42773 [details] More WebC*.h files

Dimitri Glazkov (Google)

Comment 11 2009-11-09 11:26:11 PST

Comment on attachment 42773 [details] More WebC*.h files r=me.

Nate Chapin

Comment 12 2009-11-09 11:42:51 PST

Created attachment 42775 [details] Last of the WebC*.h files

Nate Chapin

Comment 13 2009-11-09 12:13:10 PST

Created attachment 42777 [details] WebData*.h

Yaar Schnitman

Comment 14 2009-11-09 12:24:19 PST

Created attachment 42778 [details] Upstreaming WebVector ... WebWorkerClient

Yaar Schnitman

Comment 15 2009-11-09 12:30:02 PST

Created attachment 42780 [details] WebURL and friends

Dimitri Glazkov (Google)

Comment 16 2009-11-09 12:32:58 PST

Comment on attachment 42775 [details] Last of the WebC*.h files r=me.

Yaar Schnitman

Comment 17 2009-11-09 12:33:40 PST

Created attachment 42781 [details] WebText and Friends

Dimitri Glazkov (Google)

Comment 18 2009-11-09 12:34:12 PST

Comment on attachment 42777 [details] WebData*.h r=me.

Yaar Schnitman

Comment 19 2009-11-09 12:36:26 PST

Created attachment 42783 [details] WebString and other basic objects.

Yaar Schnitman

Comment 20 2009-11-09 12:40:30 PST

Created attachment 42784 [details] WebSockets and WebStorage.

Yaar Schnitman

Comment 21 2009-11-09 12:44:04 PST

Created attachment 42785 [details] WebScreenInfo to WebSharedWorkerRepo

Dimitri Glazkov (Google)

Comment 22 2009-11-09 12:44:57 PST

Comment on attachment 42778 [details] Upstreaming WebVector ... WebWorkerClient r=me.

Dimitri Glazkov (Google)

Comment 23 2009-11-09 12:47:49 PST

Comment on attachment 42780 [details] WebURL and friends r=me.

Nate Chapin

Comment 24 2009-11-09 13:04:21 PST

Created attachment 42787 [details] WebDevTools*.h & WebDrag*.h

WebKit Commit Bot

Comment 25 2009-11-09 13:06:53 PST

Comment on attachment 42778 [details] Upstreaming WebVector ... WebWorkerClient Clearing flags on attachment: 42778 Committed r50681: <http://trac.webkit.org/changeset/50681>

Eric Seidel (no email)

Comment 26 2009-11-09 13:07:56 PST

Comment on attachment 42781 [details] WebText and Friends Looks OK.

Dimitri Glazkov (Google)

Comment 27 2009-11-09 13:08:30 PST

Comment on attachment 42781 [details] WebText and Friends r=me.

Eric Seidel (no email)

Comment 28 2009-11-09 13:09:12 PST

Comment on attachment 42784 [details] WebSockets and WebStorage. Looks OK.

Dimitri Glazkov (Google)

Comment 29 2009-11-09 13:11:15 PST

Comment on attachment 42787 [details] WebDevTools*.h & WebDrag*.h r=me.

Eric Seidel (no email)

Comment 30 2009-11-09 13:12:48 PST

Comment on attachment 42787 [details] WebDevTools*.h & WebDrag*.h There are some named args here which don't need them: + WEBKIT_API static WebDevToolsFrontend* create(WebView* view, + WebDevToolsFrontendClient* client, I'm not a huge fan of the WEBKIT_IMPLEMENTATION approach, but we should discuss that more after this all lands. Looks good.

WebKit Commit Bot

Comment 31 2009-11-09 13:14:26 PST

Comment on attachment 42780 [details] WebURL and friends Clearing flags on attachment: 42780 Committed r50682: <http://trac.webkit.org/changeset/50682>

WebKit Commit Bot

Comment 32 2009-11-09 13:14:33 PST

All reviewed patches have been landed. Closing bug.

Eric Seidel (no email)

Comment 33 2009-11-09 13:17:00 PST

The closing is caused by bug 28230.

Nate Chapin

Comment 34 2009-11-09 13:17:26 PST

Created attachment 42794 [details] Remainder of WebE*.h and WebF*.h

Eric Seidel (no email)

Comment 35 2009-11-09 13:18:47 PST

Dimitri might as well review the last patch before we re-open the bug. Once it's reopened, the cq will start on it again and will close it when completed. The cq only grabs the list of patches at the start of its run. It's not smart enough to check to see if more patches were added by the time it is done landing the first one. It's just not really designed with multi-patch bugs in mind.

Dimitri Glazkov (Google)

Comment 36 2009-11-09 13:19:47 PST

Comment on attachment 42794 [details] Remainder of WebE*.h and WebF*.h r=me.

Dimitri Glazkov (Google)

Comment 37 2009-11-09 13:20:21 PST

we love cq.

Dimitri Glazkov (Google)

Comment 38 2009-11-09 13:25:19 PST

Comment on attachment 42785 [details] WebScreenInfo to WebSharedWorkerRepo r=me.

Dimitri Glazkov (Google)

Comment 39 2009-11-09 13:30:23 PST

Comment on attachment 42783 [details] WebString and other basic objects. r=me.

Nate Chapin

Comment 40 2009-11-09 13:39:50 PST

Created attachment 42797 [details] WebH*.h and WebI*.h

WebKit Commit Bot

Comment 41 2009-11-09 13:40:09 PST

Comment on attachment 42781 [details] WebText and Friends Clearing flags on attachment: 42781 Committed r50686: <http://trac.webkit.org/changeset/50686>

Dimitri Glazkov (Google)

Comment 42 2009-11-09 13:44:13 PST

Comment on attachment 42797 [details] WebH*.h and WebI*.h r=me.

WebKit Commit Bot

Comment 43 2009-11-09 13:47:41 PST

Comment on attachment 42783 [details] WebString and other basic objects. Clearing flags on attachment: 42783 Committed r50687: <http://trac.webkit.org/changeset/50687>

WebKit Commit Bot

Comment 44 2009-11-09 13:55:08 PST

Comment on attachment 42784 [details] WebSockets and WebStorage. Clearing flags on attachment: 42784 Committed r50688: <http://trac.webkit.org/changeset/50688>

Nate Chapin

Comment 45 2009-11-09 14:02:22 PST

Created attachment 42799 [details] WebKit.h through WebMedia*.h

Dimitri Glazkov (Google)

Comment 46 2009-11-09 14:03:17 PST

Comment on attachment 42799 [details] WebKit.h through WebMedia*.h r=me.

WebKit Commit Bot

Comment 47 2009-11-09 14:19:46 PST

Comment on attachment 42785 [details] WebScreenInfo to WebSharedWorkerRepo Clearing flags on attachment: 42785 Committed r50692: <http://trac.webkit.org/changeset/50692>

WebKit Commit Bot

Comment 48 2009-11-09 14:19:53 PST

All reviewed patches have been landed. Closing bug.

Nate Chapin

Comment 49 2009-11-09 14:22:07 PST

Created attachment 42801 [details] WebMessage*.h through WebNavigation*.h

Nate Chapin

Comment 50 2009-11-09 14:24:07 PST

Created attachment 42802 [details] Rest of WebN*.h

Dimitri Glazkov (Google)

Comment 51 2009-11-09 14:28:04 PST

Comment on attachment 42801 [details] WebMessage*.h through WebNavigation*.h r=me.

Dimitri Glazkov (Google)

Comment 52 2009-11-09 14:28:24 PST

cq rox0r.

Dimitri Glazkov (Google)

Comment 53 2009-11-09 14:29:14 PST

Comment on attachment 42802 [details] Rest of WebN*.h r=me.

Yaar Schnitman

Comment 54 2009-11-09 14:37:08 PST

Created attachment 42803 [details] 2009-11-09 Nate Chapin <japhet@chromium.org>

Yaar Schnitman

Comment 55 2009-11-09 14:38:37 PST

Created attachment 42804 [details] Upstreaming Chromium API src files: WebAccessibility

Nate Chapin

Comment 56 2009-11-09 14:58:10 PST

Created attachment 42805 [details] WebPa*.h and WebPl*.h

Nate Chapin

Comment 57 2009-11-09 14:58:45 PST

Created attachment 42806 [details] WebPo*.h and WebRuntimeFeatures.h

Yaar Schnitman

Comment 58 2009-11-09 17:38:49 PST

Created attachment 42815 [details] Upstreaming Chromium API: Platform specific files

Dimitri Glazkov (Google)

Comment 59 2009-11-09 20:11:36 PST

Comment on attachment 42815 [details] Upstreaming Chromium API: Platform specific files r=me.

Dimitri Glazkov (Google)

Comment 60 2009-11-09 20:14:19 PST

Comment on attachment 42805 [details] WebPa*.h and WebPl*.h r=me.

WebKit Commit Bot

Comment 61 2009-11-09 20:25:27 PST

Comment on attachment 42815 [details] Upstreaming Chromium API: Platform specific files Clearing flags on attachment: 42815 Committed r50712: <http://trac.webkit.org/changeset/50712>

WebKit Commit Bot

Comment 62 2009-11-09 20:25:34 PST

All reviewed patches have been landed. Closing bug.

Dimitri Glazkov (Google)

Comment 63 2009-11-09 20:27:43 PST

cq <3

WebKit Commit Bot

Comment 64 2009-11-09 20:58:35 PST

Comment on attachment 42805 [details] WebPa*.h and WebPl*.h Clearing flags on attachment: 42805 Committed r50716: <http://trac.webkit.org/changeset/50716>

WebKit Commit Bot

Comment 65 2009-11-09 21:06:02 PST

Comment on attachment 42806 [details] WebPo*.h and WebRuntimeFeatures.h Clearing flags on attachment: 42806 Committed r50717: <http://trac.webkit.org/changeset/50717>

WebKit Commit Bot

Comment 66 2009-11-09 21:06:09 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.