Bug 283939
| Summary: | Add initial ImageDataArray as replacement type for ImageData::m_data, for later float16 support | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Gerald Squelart <g_squelart> |
| Component: | Canvas | Assignee: | Gerald Squelart <g_squelart> |
| Status: | RESOLVED FIXED | ||
| Severity: | Enhancement | CC: | sabouhallawa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 284004 | ||
Gerald Squelart
Currently `ImageData::m_data` is a `Ref<JSC::Uint8ClampedArray>` (corresponding to ImageData.idl's `attribute ImageDataArray data`), so it can only deal with byte-sized color components like RGBA.
To allow float16 support (the idl data type will change to something like `typedef (Uint8ClampedArray or Float16Array) ImageDataArray`), `ImageData::m_data` should be able to hold other typed-array types, like `JSC::Float16Array`.
As a first step, we'll move the `Ref<JSC::Uint8ClampedArray>` to a separate class, and that class will eventually handle more types.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/140813668>
Gerald Squelart
Pull request: https://github.com/WebKit/WebKit/pull/37344
Gerald Squelart
Pull request: https://github.com/WebKit/WebKit/pull/37239
Gerald Squelart
Pull request: https://github.com/WebKit/WebKit/pull/37121
EWS
Committed 287312@main (faf054788cd8): <https://commits.webkit.org/287312@main>
Reviewed commits have been landed. Closing PR #37344 and removing active labels.