Bug 28390

Summary: WebInspector: Reset InjectedScript styles cache on document change.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
timothy: review-
patch timothy: review+

Pavel Feldman
Reported 2009-08-17 08:07:23 PDT
Reset InjectedScript styles cache on document change.
Attachments
patch (5.46 KB, patch)
2009-08-17 08:08 PDT, Pavel Feldman 		timothy: review-
DetailsFormatted DiffDiff
patch (6.42 KB, patch)
2009-08-17 10:31 PDT, Pavel Feldman 		timothy: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2009-08-17 08:08:41 PDT
Created attachment 34968 [details] patch
Timothy Hatcher
Comment 2 2009-08-17 09:33:13 PDT
Comment on attachment 34968 [details] patch _reset should be reset since it isn't private.
Pavel Feldman
Comment 3 2009-08-17 09:49:16 PDT
(In reply to comment #2) > (From update of attachment 34968 [details]) > _reset should be reset since it isn't private. The reason I made is private was that I wanted to show that it is called _not_ from the frontend, but from the InspectorController host itself (as with _createProxyObject). But I can highlight that in comments if you'd like.
Timothy Hatcher
Comment 4 2009-08-17 09:52:24 PDT
I think a comment and dropping the underscore would be best (in the case of _createProxyObject too). Anything called from another file should not have a underscore.
Pavel Feldman
Comment 5 2009-08-17 10:31:26 PDT
Created attachment 34976 [details] patch Thanks for review. Fixed the underscores!
Pavel Feldman
Comment 6 2009-08-17 10:44:12 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/InspectorController.cpp M WebCore/inspector/InspectorController.h M WebCore/inspector/InspectorDOMAgent.cpp M WebCore/inspector/InspectorDOMAgent.h M WebCore/inspector/front-end/InjectedScript.js Committed r47369
Note You need to log in before you can comment on or make changes to this bug.