| Summary: | WebInspector: Reset InjectedScript styles cache on document change. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | timothy | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Pavel Feldman
2009-08-17 08:07:23 PDT
Created attachment 34968 [details]
patch
Comment on attachment 34968 [details]
patch
_reset should be reset since it isn't private.
(In reply to comment #2) > (From update of attachment 34968 [details]) > _reset should be reset since it isn't private. The reason I made is private was that I wanted to show that it is called _not_ from the frontend, but from the InspectorController host itself (as with _createProxyObject). But I can highlight that in comments if you'd like. I think a comment and dropping the underscore would be best (in the case of _createProxyObject too). Anything called from another file should not have a underscore. Created attachment 34976 [details]
patch
Thanks for review.
Fixed the underscores!
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/InspectorController.cpp M WebCore/inspector/InspectorController.h M WebCore/inspector/InspectorDOMAgent.cpp M WebCore/inspector/InspectorDOMAgent.h M WebCore/inspector/front-end/InjectedScript.js Committed r47369 |