Bug 283764
| Summary: | [Tools][GTK][WPE] generate-bundle test suite: retry tests before marking them as a failure to avoid flaky/random/network issues | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> |
| Component: | Tools / Tests | Assignee: | Carlos Alberto Lopez Perez <clopez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, dpino, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Carlos Alberto Lopez Perez
On the nightly packaging bots we run a test step with webdriver and the bundle to ensure that it works as expected.
The problem is that this is step is randomly failing. I suspect is related with the network as some tests require loading resources from internet (videos, ssl certs, wasm files, etc)
So to make the test step more robust retry each one of the webdriver tests up to 3 times (by default) before marking it as a failure.
This should not be an issue if the generated bundle is broken as in that case it should fail the 3 times and that is what we are looking to detect with this test suite.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Alberto Lopez Perez
Examples:
https://build.webkit.org/#/builders/1321/builds/46
https://build.webkit.org/#/builders/1322/builds/46
https://build.webkit.org/#/builders/1322/builds/45
Carlos Alberto Lopez Perez
Pull request: https://github.com/WebKit/WebKit/pull/37201
EWS
Committed 287150@main (28de6f13360b): <https://commits.webkit.org/287150@main>
Reviewed commits have been landed. Closing PR #37201 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/140657628>