Bug 28376

Summary: [Cleanup] isAfterContent() implemented twice, should be member of RenderObject
Product: WebKit Reporter: Roland Steiner <rolandsteiner>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Trivial CC: eric
Priority: P3 Keywords: EasyFix
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
[patch] move implementation of isAfterContent to RenderObject none

Description Roland Steiner 2009-08-16 22:05:07 PDT
The function isAfterContent() is implemented twice, once in RenderInline as a static function, once in RenderBox.
Both implementations are equal. 

Also, there is nothing in the implementation that would prevent having this functionality available as a member on RenderObject.
Comment 1 Roland Steiner 2009-08-16 22:09:37 PDT
Created attachment 34949 [details]
[patch] move implementation of isAfterContent to RenderObject

Moved implementation of isAfterContent to RenderObject, remove from RenderBox and RenderInline.

All layout tests passed.
Comment 2 Eric Seidel (no email) 2009-08-17 17:13:52 PDT
Comment on attachment 34949 [details]
[patch] move implementation of isAfterContent to RenderObject

LGTM.
Comment 3 Eric Seidel (no email) 2009-08-17 17:58:17 PDT
Comment on attachment 34949 [details]
[patch] move implementation of isAfterContent to RenderObject

Clearing flags on attachment: 34949

Committed r47403: <http://trac.webkit.org/changeset/47403>
Comment 4 Eric Seidel (no email) 2009-08-17 17:58:21 PDT
All reviewed patches have been landed.  Closing bug.