Bug 28376

Summary: [Cleanup] isAfterContent() implemented twice, should be member of RenderObject
Product: WebKit Reporter: Roland Steiner <rolandsteiner>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Trivial CC: eric
Priority: P3 Keywords: EasyFix
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
[patch] move implementation of isAfterContent to RenderObject none

Roland Steiner
Reported 2009-08-16 22:05:07 PDT
The function isAfterContent() is implemented twice, once in RenderInline as a static function, once in RenderBox. Both implementations are equal. Also, there is nothing in the implementation that would prevent having this functionality available as a member on RenderObject.
Attachments
[patch] move implementation of isAfterContent to RenderObject (3.90 KB, patch)
2009-08-16 22:09 PDT, Roland Steiner 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Roland Steiner
Comment 1 2009-08-16 22:09:37 PDT
Created attachment 34949 [details] [patch] move implementation of isAfterContent to RenderObject Moved implementation of isAfterContent to RenderObject, remove from RenderBox and RenderInline. All layout tests passed.
Eric Seidel (no email)
Comment 2 2009-08-17 17:13:52 PDT
Comment on attachment 34949 [details] [patch] move implementation of isAfterContent to RenderObject LGTM.
Eric Seidel (no email)
Comment 3 2009-08-17 17:58:17 PDT
Comment on attachment 34949 [details] [patch] move implementation of isAfterContent to RenderObject Clearing flags on attachment: 34949 Committed r47403: <http://trac.webkit.org/changeset/47403>
Eric Seidel (no email)
Comment 4 2009-08-17 17:58:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.