| Summary: | bugzilla.py: replace ScriptError class with BugzillaError class | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aroben, eric, levin | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/Scripts/bugzilla-tool M WebKitTools/Scripts/modules/scm.py Committed r47343 M WebKitTools/Scripts/modules/scm.py M WebKitTools/Scripts/bugzilla-tool r47343 = 8671504eb06eb7308d006942678f0366b79d8c74 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk WebKitTools/ChangeLog: locally modified WebKitTools/Scripts/modules/bugzilla.py: locally modified M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/bugzilla.py Committed r47344 M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/bugzilla.py r47344 = a9ed6e27ed13e67d584fa8d64413109318bdfcda (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47343 All reviewed patches have been landed. Closing bug. (In reply to comment #1) > Committing to http://svn.webkit.org/repository/webkit/trunk ... > M WebKitTools/Scripts/bugzilla-tool > M WebKitTools/Scripts/modules/scm.py > Committed r47343 > M WebKitTools/Scripts/modules/scm.py > M WebKitTools/Scripts/bugzilla-tool > r47343 = 8671504eb06eb7308d006942678f0366b79d8c74 (trunk) > No changes between current HEAD and refs/remotes/trunk > Resetting to the latest refs/remotes/trunk This was a mistake. Backed out in r47345 again. <http://trac.webkit.org/changeset/47343> <http://trac.webkit.org/changeset/47345> > WebKitTools/ChangeLog: locally modified > WebKitTools/Scripts/modules/bugzilla.py: locally modified > M WebKitTools/ChangeLog > M WebKitTools/Scripts/modules/bugzilla.py > Committed r47344 > M WebKitTools/ChangeLog > M WebKitTools/Scripts/modules/bugzilla.py > r47344 = a9ed6e27ed13e67d584fa8d64413109318bdfcda (trunk) > No changes between current HEAD and refs/remotes/trunk > Resetting to the latest refs/remotes/trunk <http://trac.webkit.org/changeset/47344> |
Created attachment 34938 [details] Patch v1 Reviewed by NOBODY (OOPS!). The ScriptError class doesn't exist in bugzilla.py, so any errors print error messages about ScriptError instead of the actual error: NameError: global name 'ScriptError' is not defined * Scripts/modules/bugzilla.py: (BugzillaError): Added class. Modeled after ScriptError class in scm.py. (Bugzilla.authenticate): Changed to use BugzillaError instead of ScriptError. (Bugzilla._check_create_bug_response): Ditto. --- 2 files changed, 26 insertions(+), 2 deletions(-)