WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
28367
bugzilla.py: replace ScriptError class with BugzillaError class
https://bugs.webkit.org/show_bug.cgi?id=28367
Summary
bugzilla.py: replace ScriptError class with BugzillaError class
David Kilzer (:ddkilzer)
Reported
2009-08-16 15:16:03 PDT
Created
attachment 34938
[details]
Patch v1 Reviewed by NOBODY (OOPS!). The ScriptError class doesn't exist in bugzilla.py, so any errors print error messages about ScriptError instead of the actual error: NameError: global name 'ScriptError' is not defined * Scripts/modules/bugzilla.py: (BugzillaError): Added class. Modeled after ScriptError class in scm.py. (Bugzilla.authenticate): Changed to use BugzillaError instead of ScriptError. (Bugzilla._check_create_bug_response): Ditto. --- 2 files changed, 26 insertions(+), 2 deletions(-)
Attachments
Patch v1
(2.43 KB, patch)
2009-08-16 15:16 PDT
,
David Kilzer (:ddkilzer)
levin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1
2009-08-16 17:31:05 PDT
Committing to
http://svn.webkit.org/repository/webkit/trunk
... M WebKitTools/Scripts/bugzilla-tool M WebKitTools/Scripts/modules/scm.py Committed
r47343
M WebKitTools/Scripts/modules/scm.py M WebKitTools/Scripts/bugzilla-tool
r47343
= 8671504eb06eb7308d006942678f0366b79d8c74 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk WebKitTools/ChangeLog: locally modified WebKitTools/Scripts/modules/bugzilla.py: locally modified M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/bugzilla.py Committed
r47344
M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/bugzilla.py
r47344
= a9ed6e27ed13e67d584fa8d64413109318bdfcda (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/47343
David Kilzer (:ddkilzer)
Comment 2
2009-08-16 17:31:10 PDT
All reviewed patches have been landed. Closing bug.
David Kilzer (:ddkilzer)
Comment 3
2009-08-16 17:34:11 PDT
(In reply to
comment #1
)
> Committing to
http://svn.webkit.org/repository/webkit/trunk
... > M WebKitTools/Scripts/bugzilla-tool > M WebKitTools/Scripts/modules/scm.py > Committed
r47343
> M WebKitTools/Scripts/modules/scm.py > M WebKitTools/Scripts/bugzilla-tool >
r47343
= 8671504eb06eb7308d006942678f0366b79d8c74 (trunk) > No changes between current HEAD and refs/remotes/trunk > Resetting to the latest refs/remotes/trunk
This was a mistake. Backed out in
r47345
again. <
http://trac.webkit.org/changeset/47343
> <
http://trac.webkit.org/changeset/47345
>
> WebKitTools/ChangeLog: locally modified > WebKitTools/Scripts/modules/bugzilla.py: locally modified > M WebKitTools/ChangeLog > M WebKitTools/Scripts/modules/bugzilla.py > Committed
r47344
> M WebKitTools/ChangeLog > M WebKitTools/Scripts/modules/bugzilla.py >
r47344
= a9ed6e27ed13e67d584fa8d64413109318bdfcda (trunk) > No changes between current HEAD and refs/remotes/trunk > Resetting to the latest refs/remotes/trunk
<
http://trac.webkit.org/changeset/47344
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug