Bug 283626
| Summary: | VideoMediaSampleRenderer drops more frames than it should. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Component: | Media | Assignee: | Jean-Yves Avenard [:jya] <jean-yves.avenard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jean-Yves Avenard [:jya]
Following bug 283259, we can easily see the dropped frame count. And it is higher than it should be..
On a beefy Mac Studio M2 Ultra 24 cores, the frame dropped rate is about 0.5%
Similar to bug 283275, we see frames being dropped due to a difference in timescale.
Current Time is using a 10ns timescale
currentTime CMTime 17150040124 1000000000ths of a second
while the sample is using a millisecond timescale
presentationEndTime CMTime 17150 1000ths of a second
So it is dropped. But really, it's close enough and it shouldn't be
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Jean-Yves Avenard [:jya]
Analysis above on why frames were dropped was incorrect. Incoming fix.
Jean-Yves Avenard [:jya]
rdar://140515014
Jean-Yves Avenard [:jya]
Pull request: https://github.com/WebKit/WebKit/pull/37107
EWS
Committed 287074@main (88039a970adb): <https://commits.webkit.org/287074@main>
Reviewed commits have been landed. Closing PR #37107 and removing active labels.