Bug 283590
| Summary: | ComputedStyleExtractor should check renderers for margin values | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sammy Gill <sgill26> |
| Component: | CSS | Assignee: | Sammy Gill <sgill26> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | koivisto, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 283508 | ||
Sammy Gill
If we have a valid renderer, then we should just check it for the used margin values since we already store them there. Even if the value is fixed we need to check the renderer because certain properties can result in the used value being different (e.g. margin-trim or block-step-size)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/140439313>
Sammy Gill
Pull request: https://github.com/WebKit/WebKit/pull/37048
EWS
Committed 287196@main (5a0b0f236dce): <https://commits.webkit.org/287196@main>
Reviewed commits have been landed. Closing PR #37048 and removing active labels.