Bug 283507
| Summary: | Pack CSS::PrimitiveNumeric | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> |
| Component: | New Bugs | Assignee: | Sam Weinig <sam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari 18 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sam Weinig
Pack CSS::PrimitiveNumeric by replacing std::variant with a union, and using the CSSUnitType to determine the correct alternative.
An alternative we may want to explore in the future when we no longer have the old CSSValue system around is creating a type per unit (e.g. Px { double value; }; Em { double value; }; ...) and using a std::variant with them, but since we still need to utilize CSSUnitTypes for the moment, that would be less efficient.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Weinig
Pull request: https://github.com/WebKit/WebKit/pull/36966
EWS
Committed 286978@main (2ba07c2f90a7): <https://commits.webkit.org/286978@main>
Reviewed commits have been landed. Closing PR #36966 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/140435621>