Bug 28337

Summary: Fix build for ports which don't enable JIT.
Product: WebKit Reporter: Maxime Simon <simon.maxime>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch v1 none

Maxime Simon
Reported 2009-08-15 01:29:20 PDT
In changeset 47304 a new header were introduced, Executable.h. When compiling a port which doesn't support JIT it fails on this header because the JITCode& jitCode() function isn't surrounded by "#if ENABLE(JIT) … #endif". Maxime
Attachments
Patch v1 (1.19 KB, patch)
2009-08-15 01:32 PDT, Maxime Simon 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Maxime Simon
Comment 1 2009-08-15 01:32:59 PDT
Created attachment 34893 [details] Patch v1
Maxime Simon
Comment 2 2009-08-16 00:15:23 PDT
Bug also seen on Leopard PPC.
Maxime Simon
Comment 3 2009-08-17 03:21:27 PDT
Corrected at r47330
Eric Seidel (no email)
Comment 4 2009-08-17 17:11:07 PDT
Comment on attachment 34893 [details] Patch v1 A similar patch was landed as http://trac.webkit.org/changeset/47330. No need for this to be in the review queue anymore. :)
Maxime Simon
Comment 5 2009-08-17 22:04:02 PDT
(In reply to comment #4) > (From update of attachment 34893 [details]) > A similar patch was landed as http://trac.webkit.org/changeset/47330. No need > for this to be in the review queue anymore. :) Indeed, but like the bug 28339 which also received a fix before being reviewed, I marked this one as closed. But I should also tag as obsolete the patches, that's not automatique. ;)
Note You need to log in before you can comment on or make changes to this bug.