Bug 28330

Summary: Remove AST nodes from use within the Runtime (outside of parsing), stage 1
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
The Patch oliver: review+

Gavin Barraclough
Reported 2009-08-14 16:21:45 PDT
Remove the EvalNode and ProgramNode from use in the runtime. They still exist after this patch, but are hidden behind EvalExecutable and FunctionExecutable, and are also still reachable behind CodeBlock::m_ownerNode. The next step will be to beat back FunctionBodyNode in the same fashion. Then remove the usage via CodeBlock, then only construct these nodes only on demand during bytecode generation.
Attachments
The Patch (42.23 KB, patch)
2009-08-14 17:00 PDT, Gavin Barraclough 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2009-08-14 17:00:10 PDT
Created attachment 34881 [details] The Patch
Oliver Hunt
Comment 2 2009-08-14 17:07:50 PDT
Comment on attachment 34881 [details] The Patch r=me!
Gavin Barraclough
Comment 3 2009-08-14 18:42:09 PDT
fixed in http://trac.webkit.org/changeset/47304
Note You need to log in before you can comment on or make changes to this bug.