Bug 28326 – DRT on Windows doesn't support LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Brian Weinstein]

DRT on Windows doesn't support LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota.

[Brian Weinstein]

Created attachment 34978 [details]
Fix

[Eric Seidel (no email)]

Comment on attachment 34978 [details]
Fix

I'm confused by this code:
     COMPtr<IWebDatabaseManager> databaseManager;
 731     COMPtr<IWebDatabaseManager> tmpDatabaseManager;
 732 
 733     if (FAILED(WebKitCreateInstance(CLSID_WebDatabaseManager, 0, IID_IWebDatabaseManager, (void**)&tmpDatabaseManager)))
 734         return;
 735     if (FAILED(tmpDatabaseManager->sharedWebDatabaseManager(&databaseManager)))
 736         return;

Maybe it could be explained in a comment or the ChangeLgo why you need two IWebDatabaseManager pointers there?

[Brian Weinstein]

I got that code from a different function in the same file that used the same way of getting the real database manager. I can do a little legwork there and figure out why it's doing that though.

[Brian Weinstein]

Committed in http://trac.webkit.org/changeset/47447