Bug 283253
| Summary: | Refactor webkitscmpy.program.canonicalize.message to be more testable | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
| Component: | Tools / Tests | Assignee: | Sam Sneddon [:gsnedders] <gsnedders> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sam Sneddon [:gsnedders]
Currently it's a singular, big main function.
We should split it up to call into a smaller `rewrite_message` which can be tested in isolation.
https://github.com/WebKit/WebKit/pull/36498 added a lot of tests here, but it does so in the same way as the existing tests: with a huge amount of setup, relying on our git mock, rather than testing the unit we actually care about here: how we rewrite the message.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Sneddon [:gsnedders]
Pull request: https://github.com/WebKit/WebKit/pull/36768
Radar WebKit Bug Importer
<rdar://problem/140487902>
EWS
Committed 287298@main (d07c38a4698e): <https://commits.webkit.org/287298@main>
Reviewed commits have been landed. Closing PR #36768 and removing active labels.