Too much use of void* in Grammar.y

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Darin Adler]

Need to fix up the type casting and a couple other things in the Grammar.y file.

[Darin Adler]

Created attachment 34798 [details]
patch

[George Staikos]

Generally nice patch, though it does a lot more than just void* cleanup.  It's safe to assume you don't have a clean way to split the different changes up?

[Darin Adler]

(In reply to comment #2)
> Generally nice patch, though it does a lot more than just void* cleanup.  It's
> safe to assume you don't have a clean way to split the different changes up?

It could easily be split into pieces. Since all these changes are mechanical I thought someone might review them in this form.

[Darin Adler]

Note that this patch itself is basically a broken out piece of <https://bugs.webkit.org/attachment.cgi?id=30279&action=prettypatch>.

[George Staikos]

Comment on attachment 34798 [details]
patch

I've been doing so.  I'm happy to r+ this as-is but I think it would be nicer to commit it in a few pieces.

[Darin Adler]

http://trac.webkit.org/changeset/47256
http://trac.webkit.org/changeset/47257
http://trac.webkit.org/changeset/47258
http://trac.webkit.org/changeset/47259
http://trac.webkit.org/changeset/47262
http://trac.webkit.org/changeset/47263