Bug 28286

Summary: bugzilla-tool/commit-queue needs to upload failure logs when patches are rejected
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, kbr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch abarth: review+, eric: commit-queue+

Description Eric Seidel (no email) 2009-08-13 16:16:30 PDT 
bugzilla-tool/commit-queue needs to upload failure logs when patches are rejected

the commit-queue script I'm running keeps a log locally.  But bugzilla-tool/commit-queue is not smart enough to know how to upload that log to the bug when a failure occurs.

it will also need to split out just the relevant sections of the log.

Adding these logs to bugs would clear up a lot of confusion around the commit-queue.
Comment 1 Eric Seidel (no email) 2009-12-15 02:21:52 PST 
For now we're going to upload the failure logs to app engine instead of the bug.  We could change things to upload them to the bug as well at a later date.
Comment 2 Eric Seidel (no email) 2009-12-15 02:26:01 PST 
Created attachment 44854 [details]
Patch
Comment 3 WebKit Review Bot 2009-12-15 02:30:14 PST 
style-queue ran check-webkit-style on attachment 44854 [details] without any errors.
Comment 4 Adam Barth 2009-12-15 02:30:55 PST 
Comment on attachment 44854 [details]
Patch

Nice!  One step closer to real ultimate power.
Comment 5 Eric Seidel (no email) 2009-12-15 02:39:27 PST 
Committed r52147: <http://trac.webkit.org/changeset/52147>