Bug 282841
| Summary: | [css-masonry] Update Intrinsic Sizing Rows 003 Auto Expected / Ref Test Case | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brandon <brandonstewart> |
| Component: | CSS | Assignee: | Brandon <brandonstewart> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | koivisto, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Brandon
The 27.02px width when calculating “3 3” adds challenges for these tests. The Ahem font is more straightforward for the test cases as it results in a width of 27px.
* Grid 2
We cannot create an invisible item, because it would add a gap at the end of the grid.
Modify 5 5 to be a height of 2ch to match the original test case.
* Grid 4
The item 3 3 should not span 2 columns, because it creates an empty column that adds a gap to the end of the grid.
* Grid 5
Same problem as grid 4.
* Grid 6
Same problem as grid 4.
Removed the extra 5 not found in the original test case.
* Grid 7-9
Creating an empty column 2 causes problems because there is now an extra grid gap that causes an extra 2px gap between the columns.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/139521637>
Brandon
Pull request: https://github.com/WebKit/WebKit/pull/36403
EWS
Committed 286454@main (6522954a8084): <https://commits.webkit.org/286454@main>
Reviewed commits have been landed. Closing PR #36403 and removing active labels.