Bug 282799
| Summary: | [CMake] Only override find_package on Apple targets | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> |
| Component: | CMake | Assignee: | Don Olmstead <don.olmstead> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | max |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Don Olmstead
...
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Don Olmstead
Pull request: https://github.com/WebKit/WebKit/pull/36365
Max Schmitt
Note: This fixes a vcpkg/cmake recursion issue when
export CMAKE_TOOLCHAIN_FILE=/c/vcpkg/scripts/buildsystems/vcpkg.cmake
got used:
CMake Error at C:/vcpkg/scripts/buildsystems/vcpkg.cmake:774 (if):
Maximum recursion depth of 1000 exceeded
Call Stack (most recent call first):
....
C:/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
C:/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
C:/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
Source/cmake/WebKitFindPackage.cmake:36 (_find_package)
Source/cmake/OptionsWin.cmake:59 (find_package)
Source/cmake/WebKitCommon.cmake:237 (include)
CMakeLists.txt:16 (include)
EWS
Committed 286337@main (795afa80a9cc): <https://commits.webkit.org/286337@main>
Reviewed commits have been landed. Closing PR #36365 and removing active labels.