Bug 282754

Summary: [macOS wk2 x86_64 ] 2 tests in imported/w3c/web-platform-tests/css/css-shapes/shape-outside/supported-shapes are a constant failure
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ntim, simon.fraser, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
[fast-cq]Patch none

zalan
Reported 2024-11-07 05:39:54 PST
<rdar://139405428>
Attachments
Patch (2.87 KB, patch)
2024-11-07 05:41 PST, zalan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (3.98 KB, patch)
2024-11-07 08:14 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2024-11-07 05:41:36 PST
Created attachment 473166 [details] Patch
zalan
Comment 2 2024-11-07 08:14:33 PST
Created attachment 473167 [details] [fast-cq]Patch
Simon Fraser (smfr)
Comment 3 2024-11-07 10:13:35 PST
Comment on attachment 473167 [details] [fast-cq]Patch View in context: https://bugs.webkit.org/attachment.cgi?id=473167&action=review > LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-outside/supported-shapes/inset/shape-outside-inset-022.html:13 > + <meta name="fuzzy" content="maxDifference=2; totalPixels=1" /> You want 0-2 and 0-1 > LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-outside/supported-shapes/inset/shape-outside-inset-025.html:13 > + <meta name="fuzzy" content="maxDifference=2; totalPixels=1" /> Ditto
zalan
Comment 4 2024-11-07 11:23:34 PST
(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 473167 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=473167&action=review > > > LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-outside/supported-shapes/inset/shape-outside-inset-022.html:13 > > + <meta name="fuzzy" content="maxDifference=2; totalPixels=1" /> > > You want 0-2 and 0-1 I think (and correct me if I'm wrong) 0-2 also includes the max-difference of 1 which is never the case (at lease not currently) while 2 means 0 and 2 which is a more accurate representation of what's failing here.
EWS
Comment 5 2024-11-08 05:23:38 PST
Committed 286330@main (ffd140a12a74): <https://commits.webkit.org/286330@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 473167 [details].
Tim Nguyen (:ntim)
Comment 6 2025-01-02 15:34:37 PST
(In reply to zalan from comment #4) > (In reply to Simon Fraser (smfr) from comment #3) > > Comment on attachment 473167 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=473167&action=review > > > > > LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-outside/supported-shapes/inset/shape-outside-inset-022.html:13 > > > + <meta name="fuzzy" content="maxDifference=2; totalPixels=1" /> > > > > You want 0-2 and 0-1 > I think (and correct me if I'm wrong) 0-2 also includes the max-difference > of 1 which is never the case (at lease not currently) while 2 means 0 and 2 > which is a more accurate representation of what's failing here. 0-2 / 0-1 is correct, 2/1 will strictly match and cause the test to fail in other browsers if they 100% match.
Note You need to log in before you can comment on or make changes to this bug.