Bug 282638
| Summary: | [css-masonry] Refactor Overriding of Logical Width during Masonry | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brandon <brandonstewart> |
| Component: | CSS | Assignee: | Brandon <brandonstewart> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | koivisto, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Brandon
The overriding logical width logic should live in the GridMasonryLayout instead of RenderGrid.
Added an enum to handle the different min, max, and not overriding cases.
There was one special behavior with subgrid containers not being iterated over in the old implementation. I added extra code to handle this behavior.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/139312026>
Brandon
Pull request: https://github.com/WebKit/WebKit/pull/36215
EWS
Committed 286276@main (578b0cd616d2): <https://commits.webkit.org/286276@main>
Reviewed commits have been landed. Closing PR #36215 and removing active labels.